973795 - Fix -Wreorder and -Wsign-compare warnings in nsThreadPool.cpp

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: fix-nsThreadPool-warnings.patch

The following clang warnings were introduced by bug 968016:

xpcom/threads/nsThreadPool.cpp:55:5 [-Wreorder] field 'mStackSize' will be initialized after field 'mIdleCount'

xpcom/threads/nsThreadPool.cpp:259:26 [-Wsign-compare] comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'int32_t' (aka 'int')

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8377410 [details] [diff] [review]
fix-nsThreadPool-warnings.patch

Review of attachment 8377410 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/base/nsConsoleService.cpp
@@ +139,5 @@
>      mService->EnumerateListeners(CollectCurrentListeners, &listeners);
>  
>      mService->SetIsDelivering();
>  
> +    for (uint32_t i = 0; i < listeners.Count(); ++i)

Looks like the *adds* a warning: nsCOMArray::Count returns int32_t; nsCOMArray::Length returns uint32_t.

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: fix-nsThreadPool-warnings-v2.patch

oops, I forgot to hg qrefresh some patch changes.

Comment 3

[Chris Peterson [:cpeterson]]

(In reply to :Ms2ger from comment #1)
> Looks like the *adds* a warning: nsCOMArray::Count returns int32_t;
> nsCOMArray::Length returns uint32_t.

yes, that was a mistake. I forgot one final hg qrefresh before posting my initial patch. :\

Comment 4

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ed161be44ec3

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ed161be44ec3