973822 - TypeError: window.wrappedJSObject.LockScreen.unlock is not a function during setup

Status: RESOLVED FIXED

(Testing Graveyard :: Eideticker, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Bug 960901 made necessary changes to gaiatest, however these changes are not yet available on the version released to PyPI. We either need to bump the version number again and release, or change eideticker-ci to use the checked out version of gaiatest rather than use the PyPI version. In fact, we should probably do both.

Traceback (most recent call last):
  File "./bin/update-dashboard.py", line 298, in <module>
Using adb interface (type: b2g, host: None, port: None, debuglevel: 20)
Using adb interface (type: b2g, host: None, port: None, debuglevel: 20)
    main()
  File "./bin/update-dashboard.py", line 280, in main
    eideticker.prepare_test(testkey, device_prefs)
  File "/home/mozilla/eideticker-ci/jenkins-master/jobs/b2g.inari.mozilla-central.master.tests/workspace/eideticker/src/eideticker/eideticker/runtest.py", line 41, in prepare_test
    device.unlock()
  File "/home/mozilla/eideticker-ci/jenkins-master/jobs/b2g.inari.mozilla-central.master.tests/workspace/eideticker/src/eideticker/eideticker/device.py", line 479, in unlock
    self.gaiaDevice.unlock()
  File "/home/mozilla/eideticker-ci/jenkins-master/jobs/b2g.inari.mozilla-central.master.tests/workspace/.env/local/lib/python2.7/site-packages/gaiatest/gaia_test.py", line 838, in unlock
    result = self.marionette.execute_async_script('GaiaLockScreen.unlock()')
  File "/home/mozilla/eideticker-ci/jenkins-master/jobs/b2g.inari.mozilla-central.master.tests/workspace/.env/local/lib/python2.7/site-packages/marionette/marionette.py", line 1149, in execute_async_script
    filename=os.path.basename(frame[0]))
  File "/home/mozilla/eideticker-ci/jenkins-master/jobs/b2g.inari.mozilla-central.master.tests/workspace/.env/local/lib/python2.7/site-packages/marionette/marionette.py", line 605, in _send_message
    self._handle_error(response)
  File "/home/mozilla/eideticker-ci/jenkins-master/jobs/b2g.inari.mozilla-central.master.tests/workspace/.env/local/lib/python2.7/site-packages/marionette/marionette.py", line 640, in _handle_error
    raise JavascriptException(message=message, status=status, stacktrace=stacktrace)
marionette.errors.JavascriptException: JavascriptException: TypeError: window.wrappedJSObject.LockScreen.unlock is not a function
stacktrace:
	execute_async_script @gaia_test.py, line 838
	inline javascript, line 941
	src: "        window.wrappedJSObject.LockScreen.unlock(true);"

Comment 1

[William Lachance (:wlach)]

One wrinkle of this is that after we apply this change, Eideticker will no longer work with older builds.

I am honestly not sure about the idea of using the checked out version of gaiatest on the dashboard-- there is the implication then that the checked out version of Eideticker may not necessarily work, which we don't really want.

Comment 2

[William Lachance (:wlach)]

Released new version of gaiatest in bug 973924. Updated eideticker to use it.

Comment 3

[William Lachance (:wlach)]

https://github.com/mozilla/eideticker/commit/d4043e384ef72ed3b2c6680bbb26c8047917e11b

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to William Lachance (:wlach) from comment #1)
> One wrinkle of this is that after we apply this change, Eideticker will no
> longer work with older builds.
> 
> I am honestly not sure about the idea of using the checked out version of
> gaiatest on the dashboard-- there is the implication then that the checked
> out version of Eideticker may not necessarily work, which we don't really
> want.

That makes sense, and it looks like the CI jobs are passing again. Thanks for taking care of this.