973850 - Images are not displayed anymore in link view

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Comment 1

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Comment 2

[Jose Manuel Cantera]

Comment on attachment 8377500 [details]
Patch v1

thanks, 

please land once we get a green Travis

Comment 3

[Noemí Freire (:noemi)]

Attachment: 2014-02-18-FB_list_for_linking.png

Hi,

Just including some info about the failing scenario:

Pre-requisites:
* some FB contacts with photo already imported
* some local contacts created

STR:
1. Go to contacts and select a local contact
2. Click on "Link contact"
3. A list of FB friends is shown

Expected:
The list of FB friends include the corresponding contact photo

Actual:
Photo is missing in the list of FB friends (please see screenshot attached)

Comment 4

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/crdlc/gaia/commit/3618d765783dd5c5d3d57e3f19a2a344cc165d95

Comment 5

[Joe Cheng [:jcheng] (please needinfo)]

triage: 1.3+ for regression

Comment 6

[Jose Manuel Cantera]

Comment on attachment 8377500 [details]
Patch v1

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Changes in image loader
[User impact] if declined: high. User cannot see friend's images
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Very low
[String changes made]:

Comment 7

[bhavana bajaj [:bajaj]]

(In reply to Jose M. Cantera from comment #6)
> Comment on attachment 8377500 [details]
> Patch v1
> 
> NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to
> better understand the B2G approval process and landings.
> 
> [Approval Request Comment]
> [Bug caused by] (feature/regressing bug #): Changes in image loader
> [User impact] if declined: high. User cannot see friend's images
> [Testing completed]: Yes
> [Risk to taking this patch] (and alternatives if risky): Very low
> [String changes made]:
Hi can you help with what sort of testing was done here ? Did we run any QA automated tests or tested the patch on master(1.4) ?

Comment 8

[Cristian Rodriguez (:crdlc)]

Hi, just testing on master

Comment 9

[bhavana bajaj [:bajaj]]

Requesting QA verification on 1.3, once this is uplifted.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

(In reply to Cristian Rodriguez (:crdlc) from comment #4)
> Merged in master:
> 
> https://github.com/crdlc/gaia/commit/3618d765783dd5c5d3d57e3f19a2a344cc165d95

Please post the link to master next time instead of your fork.
v1.3: 3df4258b121fb66b4853edb05e68c8c21b18d9d5