Closed
Bug 973850
Opened 11 years ago
Closed 11 years ago
Images are not displayed anymore in link view
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(blocking-b2g:1.3+, b2g-v1.3 fixed, b2g-v1.3T fixed, b2g-v1.4 verified)
People
(Reporter: crdlc, Assigned: crdlc)
References
Details
(Keywords: regression, verifyme)
Attachments
(2 files)
190 bytes,
text/html
|
jmcf
:
review+
bajaj
:
approval-gaia-v1.3+
|
Details |
30.58 KB,
image/png
|
Details |
No description provided.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Assignee | ||
Updated•11 years ago
|
Depends on: 967277
Keywords: regression
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8377500 -
Flags: review?(jmcf)
Assignee | ||
Updated•11 years ago
|
status-b2g-v1.3:
--- → affected
status-b2g-v1.4:
--- → affected
Updated•11 years ago
|
blocking-b2g: --- → 1.3?
Comment 2•11 years ago
|
||
Comment on attachment 8377500 [details]
Patch v1
thanks,
please land once we get a green Travis
Attachment #8377500 -
Flags: review?(jmcf) → review+
Comment 3•11 years ago
|
||
Hi,
Just including some info about the failing scenario:
Pre-requisites:
* some FB contacts with photo already imported
* some local contacts created
STR:
1. Go to contacts and select a local contact
2. Click on "Link contact"
3. A list of FB friends is shown
Expected:
The list of FB friends include the corresponding contact photo
Actual:
Photo is missing in the list of FB friends (please see screenshot attached)
Assignee | ||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Target Milestone: --- → 1.4 S2 (28feb)
Comment 6•11 years ago
|
||
Comment on attachment 8377500 [details]
Patch v1
NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Changes in image loader
[User impact] if declined: high. User cannot see friend's images
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Very low
[String changes made]:
Attachment #8377500 -
Flags: approval-gaia-v1.3?(fabrice)
Comment 7•11 years ago
|
||
(In reply to Jose M. Cantera from comment #6)
> Comment on attachment 8377500 [details]
> Patch v1
>
> NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to
> better understand the B2G approval process and landings.
>
> [Approval Request Comment]
> [Bug caused by] (feature/regressing bug #): Changes in image loader
> [User impact] if declined: high. User cannot see friend's images
> [Testing completed]: Yes
> [Risk to taking this patch] (and alternatives if risky): Very low
> [String changes made]:
Hi can you help with what sort of testing was done here ? Did we run any QA automated tests or tested the patch on master(1.4) ?
Updated•11 years ago
|
Flags: needinfo?(crdlc)
Comment 9•11 years ago
|
||
Requesting QA verification on 1.3, once this is uplifted.
Keywords: verifyme
Updated•11 years ago
|
Attachment #8377500 -
Flags: approval-gaia-v1.3?(fabrice) → approval-gaia-v1.3+
Comment 10•11 years ago
|
||
(In reply to Cristian Rodriguez (:crdlc) from comment #4)
> Merged in master:
>
> https://github.com/crdlc/gaia/commit/3618d765783dd5c5d3d57e3f19a2a344cc165d95
Please post the link to master next time instead of your fork.
v1.3: 3df4258b121fb66b4853edb05e68c8c21b18d9d5
Updated•11 years ago
|
Status: RESOLVED → VERIFIED
Updated•11 years ago
|
status-b2g-v1.3T:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•