97386 - Wrong jpeg headers are used to compile jpeg decoder

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect)

Description

[cls]

For the past few days, I haven't been able to view jpeg images.  I tracked it
down to an oversight in our build config (when using MOZ_TRACK_MODULE_DEPS
anyways).  We aren't adding JPEG_REQUIRES to the appropriate REQUIRES.  On
platforms without a system installed jpeg (say, BeOS), the build dies.  On
RH6.2, even when using --without-jpeg, it winds up using the system header files
because we do not have an include path set to the local jpeg headers.

Comment 1

[cls]

Attachment: Update REQUIRES appropriately

Comment 2

[Chris McAfee]

r=mcafee

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Ah, is that why I've been crashing in my debug build every time I view PNG images?

a=dbaron (on behalf of drivers)

Comment 4

[cls]

Attachment: Non-img places that need system header avoiding REQUIRES love

Comment 5

[cls]

Patches have been checked in.

Comment 6

[Tracy Walker [:tracy]]

 verified