Closed Bug 973907 Opened 7 years ago Closed 7 years ago

[BB] include input type range in seekbars BB

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set
normal

Tracking

(b2g-v2.0 fixed)

RESOLVED FIXED
1.4 S6 (25apr)
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: arnau, Assigned: arnau)

References

Details

Attachments

(2 files)

No description provided.
Attached file patch in github
Jonathan, I have duplicated the code we already had in seekbars BB to adapt it to input type range.
The only think I cannot reproduce is the thumb animation. Do you know if transitions are supported in -moz-range-thumb?
Thanks!
Attachment #8377578 - Flags: review?(jwatt)
Arnau, what do you mean by the "thumb animation"?
You mean you can't animate 'border-width' for input[type=range]:active::-moz-range-thumb? That _should_ work.
I left a substantive comment on GH 

thanks for the work!
Comment on attachment 8377578 [details] [review]
patch in github

Hi Arnau. Sorry for the delay here. This seems fine to me from the perspective of the implementer of <input type=range>, but note that I'm not a reviewer for gaia code. Hence the f+ instead of r+. I think you also need a review from someone who's allowed to review this code.
Attachment #8377578 - Flags: review?(jwatt) → feedback+
Assignee: nobody → arnau
Comment on attachment 8407334 [details] [review]
patch in github

LGTM :)
Attachment #8407334 - Flags: review?(pivanov) → review+
Merged: a74c66bc982ee52392f6ec27ecc711aa79fae4e1
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S6 (25apr)
You need to log in before you can comment on or make changes to this bug.