973913 - ExtendedValidation.cpp fails to compile with older gcc 4.4 compiler (nullptr problem)

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Frank Wein [:mcsmurf]]

I've noticed security/certverifier/ExtendedValidation.cpp does not compile with an older gcc 4.4 compiler (which is still supported as far as I know, though higher version is recommend :):

../../../../mozilla/security/certverifier/ExtendedValidation.cpp:115:5: error: ‘nullptr’ was not declared in this scope
../../../../mozilla/security/certverifier/ExtendedValidation.cpp:129:5: error: ‘nullptr’ was not declared in this scope
../../../../mozilla/security/certverifier/ExtendedValidation.cpp:141:5: error: ‘nullptr’ was not declared in this scope
../../../../mozilla/security/certverifier/ExtendedValidation.cpp:153:5: error: ‘nullptr’ was not declared in this scope
../../../../mozilla/security/certverifier/ExtendedValidation.cpp:166:5: error: ‘nullptr’ was not declared in this scope
../../../../mozilla/security/certverifier/ExtendedValidation.cpp:179:5: error: ‘nullptr’ was not declared in this scope
../../../../mozilla/security/certverifier/ExtendedValidation.cpp:191:5: error: ‘nullptr’ was not declared in this scope
../../../../mozilla/security/certverifier/ExtendedValidation.cpp:206:5: error: ‘nullptr’ was not declared in this scope
../../../../mozilla/security/certverifier/ExtendedValidation.cpp:218:5: error: ‘nullptr’ was not declared in this scope
../../../../mozilla/security/certverifier/ExtendedValidation.cpp:232:5: error: ‘nullptr’ was not declared in this scope

and so on.
Probably need to "#include "mozilla/NullPtr.h"" in this file?

Comment 1

[Justin Wood (:Callek)]

this is broken on aurora as well

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Not sure it is worth tracking. However, I will be happy to uplift a patch in Aurora.

By the way, I am not sure gcc 4.4 is still maintained (at least from the upstream perspective)

Comment 3

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

I think a fix for this just landed in mozilla-inbound in revision b7030189c2ca. See:
https://hg.mozilla.org/integration/mozilla-inbound/diff/b7030189c2ca/security/certverifier/ExtendedValidation.cpp

Please let me know if the build now works for you.

Comment 4

[Frank Wein [:mcsmurf]]

Let's call this fixed.