Closed Bug 973913 Opened 7 years ago Closed 7 years ago

ExtendedValidation.cpp fails to compile with older gcc 4.4 compiler (nullptr problem)

Categories

(Core :: Security: PSM, defect)

All
Linux
defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla30
Tracking Status
firefox29 - affected
firefox30 - affected

People

(Reporter: mcsmurf, Unassigned)

References

Details

I've noticed security/certverifier/ExtendedValidation.cpp does not compile with an older gcc 4.4 compiler (which is still supported as far as I know, though higher version is recommend :):

../../../../mozilla/security/certverifier/ExtendedValidation.cpp:115:5: error: ‘nullptr’ was not declared in this scope
../../../../mozilla/security/certverifier/ExtendedValidation.cpp:129:5: error: ‘nullptr’ was not declared in this scope
../../../../mozilla/security/certverifier/ExtendedValidation.cpp:141:5: error: ‘nullptr’ was not declared in this scope
../../../../mozilla/security/certverifier/ExtendedValidation.cpp:153:5: error: ‘nullptr’ was not declared in this scope
../../../../mozilla/security/certverifier/ExtendedValidation.cpp:166:5: error: ‘nullptr’ was not declared in this scope
../../../../mozilla/security/certverifier/ExtendedValidation.cpp:179:5: error: ‘nullptr’ was not declared in this scope
../../../../mozilla/security/certverifier/ExtendedValidation.cpp:191:5: error: ‘nullptr’ was not declared in this scope
../../../../mozilla/security/certverifier/ExtendedValidation.cpp:206:5: error: ‘nullptr’ was not declared in this scope
../../../../mozilla/security/certverifier/ExtendedValidation.cpp:218:5: error: ‘nullptr’ was not declared in this scope
../../../../mozilla/security/certverifier/ExtendedValidation.cpp:232:5: error: ‘nullptr’ was not declared in this scope

and so on.
Probably need to "#include "mozilla/NullPtr.h"" in this file?
this is broken on aurora as well
Not sure it is worth tracking. However, I will be happy to uplift a patch in Aurora.

By the way, I am not sure gcc 4.4 is still maintained (at least from the upstream perspective)
I think a fix for this just landed in mozilla-inbound in revision b7030189c2ca. See:
https://hg.mozilla.org/integration/mozilla-inbound/diff/b7030189c2ca/security/certverifier/ExtendedValidation.cpp

Please let me know if the build now works for you.
Flags: needinfo?(bugzilla)
Flags: needinfo?(bugspam.Callek)
Assignee: nobody → brian
Status: NEW → ASSIGNED
Depends on: 921885
Target Milestone: --- → mozilla30
Assignee: brian → nobody
Let's call this fixed.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: needinfo?(bugzilla)
Flags: needinfo?(bugspam.Callek)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.