973958 - Build a tool to ensure we don't regress override rules

Status: RESOLVED WONTFIX

(Firefox Graveyard :: Webapp Runtime, defect, P3)

Description

[Marco Castelluccio [:marco]]

Attachment: WIP

I've written a small proof-of-concept tool to verify that the localization files stay in sync.

The problem is that the webapp runtime (and other products too) are overriding strings from dom/ and other directories. We need to make sure that when new strings are added (or removed) in the original files, we modify the overriding files too.

The approach I've taken is to execute the tool (during the pre-build phase) with a list of the files that need to be checked.

Comment 1

[Axel Hecht [:Pike]]

I think this would be better with a proper Parser, making this depend on bug 940103, which is to import the l10n utility code into the tree.

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 8377642 [details] [diff] [review]
WIP

Review of attachment 8377642 [details] [diff] [review]:
-----------------------------------------------------------------

For this patch, I'm not sure where we should hook this up.

It seems that at least the checker code should be next to the file that's overloaded, if not even in a generic build location.

But that's probably more something for our build guys to guide on.

Comment 3

[Marco Castelluccio [:marco]]

Is there any documentation about the l10n utility API?

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Per bug 1238079, we're going to disable the desktop web runtime and remove it from the codebase, so we won't fix these bugs in it.