Closed
Bug 973991
Opened 11 years ago
Closed 11 years ago
Remove unused files in Goggles
Categories
(Webmaker Graveyard :: X-Ray Goggles, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: alicoding, Assigned: alicoding)
Details
Attachments
(1 file)
We need to clean up duplicate files that we used to have from the old Webxray and only keep the one we really use. Also, in Express 4.0 they won't support app.VERB so we need to make sure we serve the right file there.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8377680 -
Flags: review?(pomax)
Comment on attachment 8377680 [details] [review]
https://github.com/mozilla/goggles.webmaker.org/pull/98
some comments in the PR
Attachment #8377680 -
Flags: review?(pomax) → review-
|
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 8377680 [details] [review]
https://github.com/mozilla/goggles.webmaker.org/pull/98
Fixed
Attachment #8377680 -
Flags: review- → review?(pomax)
Comment on attachment 8377680 [details] [review]
https://github.com/mozilla/goggles.webmaker.org/pull/98
works for me.
Attachment #8377680 -
Flags: review?(pomax) → review+
|
||
Comment 5•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/goggles.webmaker.org
https://github.com/mozilla/goggles.webmaker.org/commit/57cc4fa177ea9381a97cf6392b8638f8b911d466
Bug 973991 - Remove unused files in Goggles
|
|
Assignee | |
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•