974045 - don't store JS_CRASH_DIAGNOSTICS variables when we don't need to

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nathan Froyd [:froydnj]]

Some compilers are intelligent about eliminating write-only variables.
Some are not.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: don't store JS_CRASH_DIAGNOSTICS variables when we don't need to

Jan Hubicka from GCC pointed out that we don't use these variables if
JS_CRASH_DIAGNOSTICS is undefined.  Since that macro is indeed undefined for
non-nightly builds, this patch gives us a nice and easy 96K space win for
release builds.

Comment 2

[Luke Wagner [:luke]]

Comment on attachment 8377749 [details] [diff] [review]
don't store JS_CRASH_DIAGNOSTICS variables when we don't need to

Wow, nice.

Comment 3

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fc7603eef263

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fc7603eef263