974048 - Improve waiting for wifi in wifi connection tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Zac C (:zac)]

Instead of waiting for some wifi networks listed, let's wait for the actual one we want to be there.

Comment 1

[Zac C (:zac)]

Attachment: github pr

Andrei this change might help stability on v1.3

Comment 2

[Askeing Yen[:askeing][:fyen]]

Comment on attachment 8377775 [details] [review]
github pr

r+

Comment 3

[[:AndreiH]]

Comment on attachment 8377775 [details] [review]
github pr

On master, this works fine.
I will tests this on v1.3 also.

Comment 4

[[:AndreiH]]

Zac I got some intermittents here [1] when waiting for _password_input_locator
[1] https://github.com/zacc/gaia/blob/bug_974048/tests/python/gaia-ui-tests/gaiatest/apps/settings/regions/wifi.py#L40

I think that we will have a stronger wait if we change it to something like
self.wait_for_condition(lambda m: (ok.location['x'] + ok.size['width']) == screen_width)

the locator being the ok button:
https://github.com/zacc/gaia/blob/bug_974048/tests/python/gaia-ui-tests/gaiatest/apps/settings/regions/wifi.py#L43

Comment 5

[Zac C (:zac)]

ok thanks AndreiH! Actually I only checked this on open wifi  :/ so thanks.

Fortunately this is not blocking so I'll try to get to this later today or tomorrow.

Comment 6

[[:AndreiH]]

Ok Zac, thanks!

I will make the changes for v1.3 and I will start and adhoc job to see the results

Comment 7

[[:AndreiH]]

Attachment: PR on v1.3 https://github.com/mozilla-b2g/gaia/pull/16447

Comment 8

[Zac C (:zac)]

Merged:
https://github.com/mozilla-b2g/gaia/commit/c04786dc0fe892da79b1d1443cc43292b83fbe05

v1.3 merged:
https://github.com/mozilla-b2g/gaia/commit/295c15a1c19f5ce064e18af61bc6315903e543dc

Comment 9

[Zac C (:zac)]

Comment on attachment 8378217 [details] [review]
PR on v1.3 https://github.com/mozilla-b2g/gaia/pull/16447

r+