974101 - Media.OpusEncoder_Init gtest spits out warnings and assertion failures

Status: RESOLVED INVALID

(Core :: Audio/Video: Recording, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Reproducible on try and locally when running "mach gtest"

TEST-START | Media.OpusEncoder_Init
[9695] WARNING: NS_ENSURE_TRUE((aChannels <= MAX_SUPPORTED_AUDIO_CHANNELS) && (aChannels > 0)) failed: file /builds/slave/try-osx64-d-000000000000000000/build/content/media/encoder/OpusTrackEncoder.cpp, line 153
[9695] WARNING: NS_ENSURE_TRUE((aChannels <= MAX_SUPPORTED_AUDIO_CHANNELS) && (aChannels > 0)) failed: file /builds/slave/try-osx64-d-000000000000000000/build/content/media/encoder/OpusTrackEncoder.cpp, line 153
[9695] WARNING: NS_ENSURE_TRUE((aChannels <= MAX_SUPPORTED_AUDIO_CHANNELS) && (aChannels > 0)) failed: file /builds/slave/try-osx64-d-000000000000000000/build/content/media/encoder/OpusTrackEncoder.cpp, line 153
[9695] WARNING: NS_ENSURE_TRUE(mSamplingRate > 0) failed: file /builds/slave/try-osx64-d-000000000000000000/build/content/media/encoder/OpusTrackEncoder.cpp, line 179
[9695] WARNING: NS_ENSURE_TRUE(mSamplingRate > 0) failed: file /builds/slave/try-osx64-d-000000000000000000/build/content/media/encoder/OpusTrackEncoder.cpp, line 179
TEST-PASS | Media.OpusEncoder_Init | test completed (time: 79ms)

Note that there is another failure you might run into when running gtest locally, in Layers.TextureSerialization - this is being tracked by bug 969388 but you should be able to disable that test temporarily.

Comment 1

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Hi  Kartikaya, 
That test would try to pass the invalid argument to our module, and it would return by NS_ENSURE_TRUE in OpusTrackEncoder.cpp also outout warning msg on console.
I think it's reasonable for this case.
What's the main problem for this one?

Comment 2

[Shelly Lin [:shelly]]

Your log shows no "TEST-UNEXPECTED-FAIL" thus the test result is good.

In fact, there are five EXPECT_FALSE in this test, which means it is "correct" to see those warnings.
http://dxr.mozilla.org/mozilla-central/source/content/media/gtest/TestTrackEncoder.cpp#52

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Ah, I see. Sorry for the noise then - I just kind of assumed that the warnings indicated problems, like they do in some other tests.

Comment 4

[Shelly Lin [:shelly]]

No worries, the warnings concerned me at first too, but it would be weird to drop the warnings for test case then.