974179 - Backout patch to hide menus in editing mode

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

Bug 956858 added code to not show menus when the phone is in editing mode. This led to the strange circumstances where hardware menu buttons work if your screen looks like:
http://dl.dropboxusercontent.com/u/72157/menu1.png

but not if it looks like:
http://dl.dropboxusercontent.com/u/72157/menu2.png

which leads you to think we're broken. I'm not even sure the designs in bug 965548 would fix the broken feeling but Ian gave the go ahead to do that or back this out.

Filing a new bug for this so its easier to track uplift.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

backout patch

Comment 2

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/ea5b6c686ce2

Comment 3

[Wesley Johnston (:wesj)]

Comment on attachment 8377925 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 956858
User impact if declined: Confusing behavior of menu
Testing completed (on m-c, etc.): Landed on mc today. This is a backout though.
Risk to taking this patch (and alternatives if risky): Low risk. 
String or IDL/UUID changes made by this patch: none.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ea5b6c686ce2

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/57a7218fd75c

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d0d4ffbe41c9

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/d0d4ffbe41c9