974196 - Button label is missing while installing an app AND after cancelling an install

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P2)

Description

[krupa raj[:krupa]]

Attachment: screenshot

Android: 4.4.2
Firefox mobile: 30.0a1(2014-02-18)

steps to reproduce:
1. Load marketplace-dev on the latest firefox mobile nightly
2. In the 'New' tab, click on the install button

expected behavior:
After the click event, button label changes to loading spinner
Upon canceling the click event, button label returns to 'Free'

actual behavior:
After the click event, button label is blank
Upon canceling the click event, button label doesn't return to 'Free'

Comment 1

[Mark Striemer [:mstriemer]]

Do you have ashes for this krupa? I have an update to make the work 'Free' return but I can't reproduce the no-spinner situation.

Comment 2

[krupa raj[:krupa]]

ashes: dfa51

Comment 3

[Mark Striemer [:mstriemer]]

My update to hide the spinner when the user returns to marketplace causes the fxos packaged app installation spinner to hide as well. That spinner will automatically go away after 30 seconds but if the app downloads fairly quickly it will show a spinner until the download is completed.

It seems to me that cancelling the android app install dialog should trigger the error callback. This is what happens on fxos and why the spinner goes away there. On desktop the spinner keeps spinning but you can also click in the address bar to install later (although installing and cancelling multiple apps loses the ability to install).

Comment 4

[Mark Striemer [:mstriemer]]

I filed bug 978143 to get the `onerror` callback triggered when the user hits cancel.

As far as the image not loading I think that's related to the other image missing errors (back arrow, screenshot/list view, etc) and I'm hoping that caching those images may help. Andy reproduced the back arrow missing and it appeared to disappear after a GC cycle so maybe the image is dropped because it has no Expires header and then needs to be downloaded again (possibly bug in not downloading again?) https://dpaste.de/8i7W.

Comment 6

[Andy McKay]

I think this is fixed with the latest platform changes.

Comment 7

[krupa raj[:krupa]]

verified fixed. Button state reverts to Free upon Cancel.