Closed
Bug 974216
Opened 11 years ago
Closed 11 years ago
Set LIBXUL_LIBRARY for LIBRARY_NAME==xul
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla30
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
1.49 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
Follow-up from bug 973142.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → ehsan
|
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8377989 -
Flags: review?(mh+mozilla)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8377989 [details] [diff] [review]
Set LIBXUL_LIBRARY for LIBRARY_NAME==xul; r=glandium
Review of attachment 8377989 [details] [diff] [review]:
-----------------------------------------------------------------
::: config/config.mk
@@ +333,5 @@
>
> # Determine if module being compiled is destined
> # to be merged into libxul
>
> ifeq ($(FINAL_LIBRARY),xul)
ifneq (,$(filter xul,$(FINAL_LIBRARY) $(LIBRARY_NAME)))
would allow to do it in one pass, with $(error LIBRARY_NAME or FINAL_LIBRARY is "xul"...)
Attachment #8377989 -
Flags: review?(mh+mozilla) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•