Closed Bug 974216 Opened 6 years ago Closed 6 years ago

Set LIBXUL_LIBRARY for LIBRARY_NAME==xul

Categories

(Firefox Build System :: General, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla30

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

Follow-up from bug 973142.
Assignee: nobody → ehsan
Attachment #8377989 - Flags: review?(mh+mozilla)
Comment on attachment 8377989 [details] [diff] [review]
Set LIBXUL_LIBRARY for LIBRARY_NAME==xul; r=glandium

Review of attachment 8377989 [details] [diff] [review]:
-----------------------------------------------------------------

::: config/config.mk
@@ +333,5 @@
>  
>  # Determine if module being compiled is destined
>  # to be merged into libxul
>  
>  ifeq ($(FINAL_LIBRARY),xul)

ifneq (,$(filter xul,$(FINAL_LIBRARY) $(LIBRARY_NAME)))

would allow to do it in one pass, with $(error LIBRARY_NAME or FINAL_LIBRARY is "xul"...)
Attachment #8377989 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/bcc5a1ceef1d
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Depends on: 977951
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.