974226 - [mozfile] remove() changes source tree permissions

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Output of `hg diff`

It seems to be adding executable bits to all of the source files - see the attached output.

Worth noting that this is after clobber fails because of bug 974225.

Comment 1

[(no longer active)]

Caused by 949600 which has been backed out.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This is actually a mozbase issue in mozfile. So moving to the right component. I think we should fix bug 974225 first before checking what's wrong here. I believe that we are wrongly handling symlinks.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Michael, would you mind to check if that is still a problem for you with my patch on bug 974225? I'm not able to get this problem reproduced locally. Do you have specific steps?

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Actually, this seems to no longer occur on fx-team changeset 750e90d5ee9a (without the given patch).

Comment 5

[Andrew Halberstadt [:ahal]]

That's because the mozbase sync got backed out. We'll need to double check when it gets re-landed.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The only reason for this might be individual symlinks which point to the idl file in the source dir. We stopped updating the permissions for symlinks. So this should be fixed by the other bug.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Ok, I checked the obj dir again and the problem was indeed $obj-dir/dist/idl. All listed idl files are symlinks to the source tree. So given that we do not change symlinks anymore, this bug is also fixed via my patch on bug 974225.