974252 - Visual Studio projects do not index NSS source files and header files are the wrong ones

Status: NEW

(Firefox Build System :: General, enhancement)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

STR:

1. Generate a visual studio project and open it.
2. Ctrl+, search for SSL_OptionSet.

Expected Results:

Visual Studio should suggest navigating to the implementation of SSL_OptionSet in security/nss/lib/ssl/sslsock.c

Actual Result:

Visual Studio suggests navigating to the declaration of SSL_OptionSet in dist/include/nss/ssl.h

There are two things wrong here:

1. The NSS source files (*.c) are not indexed.
2. The wrong copy of the NSS header files are indexed. The headers in $srcdir/security/nss/* should be indexed, not the copies in $OBJDIR/dist/include/nss.

Comment 1

[Joshua Cranmer [:jcranmer]]

I don't think this is very feasible, unless you were to port NSS to using the mozbuild infrastructure...

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

(In reply to Joshua Cranmer [:jcranmer] from comment #1)
> I don't think this is very feasible, unless you were to port NSS to using
> the mozbuild infrastructure...

I would eventually like to port NSS to mozbuild. But,  that isn't necessary for this bug. Simply excluding $OBJDIR/dist/include/nss from the include path and adding security/nss/* (for all directories that contain headers) solves the problem very well. Similarly, just brute-forcing adding security/nss/**/*.c would work much better than what we currently have.

Comment 3

[Gregory Szorc [:gps]]

We can brute force add security/nss/**/*.c and *.h to a project. IntelliSense may not be in sync with the current build configuration. But that should only apply to files under security/nss (I think).

Comment 4

[Honza Bambas (:mayhemer)]

I'm only using 'show all files' in the solution explorer and never add files to the projects.  projects are for each module (I use) in the module dir.  And intellysense works (as well as Ctrl+, and Ctrl+;) (except local variables... but that is different problem I think)

But I'm not using the generated projects, I use projects of my self.

Comment 5

[Honza Bambas (:mayhemer)]

(In reply to Honza Bambas (:mayhemer) from comment #4)
> and never add files to the projects.

Sorry, not true, I add them all and occasionally refresh/readd manually.