974292 - [Email][V1.3&V1.4] Tapping the "Done" button of mail settings page redirects to a blank page

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[William Hsu [:whsu]]

Attachment: EMAIL-Log-20140219

* Description:
  This bug happened on mail settings page.
  Tapping the "Done" button of mail settings page will redirect to a blank page if you don't successfully set up an email account.
  Here are the demo video
  - https://dc1.safesync.com/LMtBTPyk/WP_20140219_009.mp4?a=kVg5LOgvLJA

  Also, attach the log.
  - EMAIL-Log-20140219

* Precondition:
  An email account has been set up on email app

* Reproduction steps:
  1. Go to mail settings page of email app
  2. Tap "Add Account"
  3. Input a correct email account but wrong password on password field
  4. Tap "Next"
  5. After you see the warning message - "Invalid username or password", please tap "<" icon.
  6. Tap "Done" button on the mail settings page.

* Expected result:
  Email app redirect to inbox or main page

* Actual result:
  A blank page shows on email app

* Test build:
  + V1.3
   - Gaia      26e8a950f3ac703310ee8efcb741ff2418e9d190
   - Gecko     https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/ecdc275e9741
   - BuildID   20140217004003
   - Version   28.0

  + V1.4
   - Gaia      3b2fe2f86164f95db699b6ea2661925b21ecb994
   - Gecko     http://hg.mozilla.org/mozilla-central/rev/83a3ef9b2144
   - BuildID   20140202160200
   - Version   29.0a1

Comment 1

[Jason Smith [:jsmith]]

Does this reproduce on 1.1?

Comment 2

[William Hsu [:whsu]]

Not yet tested on latest V1.1.0 build
But I cannot reproduce this bug on latest V1.2.0 build.
It might be regression bug of V1.3 branch.
:)

* Build Information: (V1.2)
 - Gaia      539a25e1887b902b8b25038c547048e691bd97f6
 - Gecko     https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/28ab1d8df345
 - BuildID   20140219004001
 - Version   26.0

Comment 3

[Preeti Raghunath(:Preeti)]

Dylan

For email experience, please review.

Comment 4

[sarsenyev]

sounds like a dupe of bug 959414

Comment 5

[Jason Smith [:jsmith]]

(In reply to sarsenyev from comment #4)
> sounds like a dupe of bug 959414

I don't think so. This is involving the email app, not the Contacts app.

Comment 6

[James Burke [:jrburke]]

Attachment: GitHub pull request

This is a side effect of this change:

https://github.com/mozilla-b2g/gaia/commit/f1053cc117ebf147dad7801d32746b375b5ec599#diff-3

where `Cards.removeCardAndSuccessors(this.domNode, 'animate', 1);` was changed to `Cards.removeCardAndSuccessors(this.domNode, 'animate');`

By leaving out the "how many cards" it meant "this card and all cards after it". However, since the folder_picker is added **before** message_list in the stack, it means that all the account cards are inserted between folder_picker and message_list. So when the removeCardAndSuccessors removed the progress card, it also removed message_list.

Restoring the 1 arg fixes it. I apologize for letting this slip past before, as I had it in my head that removeCardAndSuccessors defaulted to just that one card if no arg so I did not comment on it when I saw the change.

Comment 7

[James Burke [:jrburke]]

Merged on gaia master:
https://github.com/mozilla-b2g/gaia/commit/7362a811d5af51911b4e82b989c9ad2e1602d8e3

from pull request:
https://github.com/mozilla-b2g/gaia/pull/16464

Comment 8

[Preeti Raghunath(:Preeti)]

Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: 
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:

Comment 9

[James Burke [:jrburke]]

Asking for 1.3 approval.

[Bug caused by]
Bug 869131

[User impact] if declined: 
User could see a blank screen for email, unclear how to recover from it

[Testing completed]:
The STR were followed to confirm that the blank screen no longer occurs

[Risk to taking this patch] (and alternatives if risky): 
very low, just reintroducing an argument that should not have been removed as part of the changeset for  bug 869131.

[String changes made]:
none

Comment 10

[Ryan VanderMeulen [:RyanVM]]

v1.3: 8d060acf49c62166275809f7787ee02a9299b5af

Comment 11

[William Hsu [:whsu]]

Thanks for the help.
Verified it.

* Build info.:
 + V1.4
  - Gaia      71f78f7f68fcf5e23cc5965fee0dad45289c438b
  - Gecko     https://hg.mozilla.org/mozilla-central/rev/5dc091b7e86f
  - BuildID   20140304160205
  - Version   30.0a1
  => Test Result: Canot reproduce

 + V1.3
  - Gaia      8bf848ce79ba5299b9bfe321cb8cc1585c9aa696
  - Gecko     https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/bd9ffe8b889f
  - BuildID   20140304164005
  - Version   28.0
  => Test Result: Canot reproduce