974300 - Mark /xpcom/threads as FAIL_ON_WARNINGS

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Daniel Holbert [:dholbert]]

With bug 973795 fixed, I suspect /xpcom/threads can be marked as FAIL_ON_WARNINGS.

Try run to find out:
 https://tbpl.mozilla.org/?tree=Try&rev=77ca5ef2d51d

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Here's the fix. I'll request review if the Try run goes reasonably well.

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 8378142 [details] [diff] [review]
fix

Try is green; hooray.

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8378142 [details] [diff] [review]
fix

Review of attachment 8378142 [details] [diff] [review]:
-----------------------------------------------------------------

Hooray.

Comment 4

[Daniel Holbert [:dholbert]]

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/abce7c294e38

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/abce7c294e38