Closed Bug 974300 Opened 6 years ago Closed 6 years ago

Mark /xpcom/threads as FAIL_ON_WARNINGS

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

With bug 973795 fixed, I suspect /xpcom/threads can be marked as FAIL_ON_WARNINGS.

Try run to find out:
 https://tbpl.mozilla.org/?tree=Try&rev=77ca5ef2d51d
Attached patch fixSplinter Review
Here's the fix. I'll request review if the Try run goes reasonably well.
Comment on attachment 8378142 [details] [diff] [review]
fix

Review of attachment 8378142 [details] [diff] [review]:
-----------------------------------------------------------------

Hooray.
Attachment #8378142 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/abce7c294e38
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.