Closed Bug 974347 Opened 6 years ago Closed 6 years ago

Improve bounds handling of non-rendered elements

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: longsonr, Assigned: longsonr)

Details

Attachments

(1 file)

No description provided.
Attached patch bounds.txtSplinter Review
Assignee: nobody → longsonr
Attachment #8378227 - Flags: review?(cam)
Comment on attachment 8378227 [details] [diff] [review]
bounds.txt

Review of attachment 8378227 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/svg/content/src/nsSVGPolyElement.h
@@ +37,5 @@
>    virtual nsIAtom* GetPointListAttrName() const {
>      return nsGkAtoms::points;
>    }
>  
> +  // nsSVGSVGElement methods:

s/nsSVGSVGElement/nsSVGElement/

::: layout/svg/nsSVGContainerFrame.cpp
@@ +403,2 @@
>      nsISVGChildFrame* svgKid = do_QueryFrame(kid);
> +    if (svgKid && (!content->IsSVG() ||

Add a comment here explaining why the |!content->IsSVG()| since that's not necessarily obvious.
Attachment #8378227 - Flags: review?(cam) → review+
https://hg.mozilla.org/mozilla-central/rev/f13eb52f4eb0
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.