974347 - Improve bounds handling of non-rendered elements

Status: RESOLVED FIXED

(Core :: SVG, defect)

Comment 1

[Robert Longson [:longsonr]]

Attachment: bounds.txt

Comment 2

[Robert Longson [:longsonr]]

See https://www.w3.org/Graphics/SVG/WG/track/issues/2454 and https://code.google.com/p/chromium/issues/detail?id=340960

Comment 3

[Jonathan Watt [:jwatt]]

Comment on attachment 8378227 [details] [diff] [review]
bounds.txt

Review of attachment 8378227 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/svg/content/src/nsSVGPolyElement.h
@@ +37,5 @@
>    virtual nsIAtom* GetPointListAttrName() const {
>      return nsGkAtoms::points;
>    }
>  
> +  // nsSVGSVGElement methods:

s/nsSVGSVGElement/nsSVGElement/

::: layout/svg/nsSVGContainerFrame.cpp
@@ +403,2 @@
>      nsISVGChildFrame* svgKid = do_QueryFrame(kid);
> +    if (svgKid && (!content->IsSVG() ||

Add a comment here explaining why the |!content->IsSVG()| since that's not necessarily obvious.

Comment 4

[Robert Longson [:longsonr]]

https://tbpl.mozilla.org/?tree=Try&rev=0fd2e2683346

Comment 5

[Robert Longson [:longsonr]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f13eb52f4eb0

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f13eb52f4eb0