Speed up the ceh heart beat timer to decrease wait times for restarts

VERIFIED FIXED in Firefox 30

Status

defect
P2
normal
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: jimm, Assigned: jimm)

Tracking

Trunk
Firefox 30
x86_64
Windows 8.1

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: p=1 s=it-30c-29a-28b.2 r=ff30)

Attachments

(1 attachment, 1 obsolete attachment)

953 bytes, patch
jimm
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
Posted patch fix (obsolete) — Splinter Review
Since we depend on this heart beat to handle desktop restarts, we can decrease update restart wait times by polling faster.
(Assignee)

Updated

5 years ago
Attachment #8378264 - Flags: review?(netzen)
Assignee: nobody → jmathies
Blocks: metrobacklog
Status: NEW → ASSIGNED
Priority: -- → P2
QA Contact: kamiljoz
Whiteboard: p=1 s=it-30c-29a-28b.2 r=ff30
Attachment #8378264 - Flags: review?(netzen) → review+
(Assignee)

Comment 2

5 years ago
Posted patch exportSplinter Review
Attachment #8378264 - Attachment is obsolete: true
Attachment #8378317 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/d7fdc2f9d7b5
Keywords: checkin-needed
Whiteboard: p=1 s=it-30c-29a-28b.2 r=ff30 → p=1 s=it-30c-29a-28b.2 r=ff30[fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/d7fdc2f9d7b5
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: p=1 s=it-30c-29a-28b.2 r=ff30[fixed-in-fx-team] → p=1 s=it-30c-29a-28b.2 r=ff30
Target Milestone: --- → Firefox 30
Flagged for testing and verification.
Flags: needinfo?(kamiljoz)
Went through the following verification/testing and used the following nightly build:
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-02-20-03-02-02-mozilla-central/

This is almost impossible to directly test so I went through some basic test cases to make sure the browser is still being launched/updated and restarted without any obvious regressions.

- Ensured that fxmetro restarts correctly after an update has been applied and "Restart to Update" is selected (4MB update)
- Ensured that fxmetro restarts correctly after an update has been applied and "Restart to Update" is selected (38MB update)
- Ensured fxmetro is launched every single time if it was the last environment used before closing
- Ensured fxdesktop is launched every single time if it was the last environment used before closing
- Ensured that the latest Nightly build is being launched without any issues
- Ensured that you can still switch between fxmetro and fxdesktop without any issues
- Ensured there's no performance issues when launching the browser (noticeable jank, slowdowns, flickers etc..)

Used the following builds for the updating portion of testing:
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-02-18-03-02-02-mozilla-central/
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-02-19-03-02-03-mozilla-central/
Status: RESOLVED → VERIFIED
Flags: needinfo?(kamiljoz)
You need to log in before you can comment on or make changes to this bug.