974368 - Fix ! operator precedence in manifestparser's expression parser

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[(not currently active) Ted Mielczarek]

I found a stupid bug in manifestparser's ExpressionParser, the precedence of the ! operator is broken:

>>> import manifestparser
>>> manifestparser.parse("!true || true")
False
>>> manifestparser.parse("true || !true")
True
>>> manifestparser.parse("false || true")
True

Turns out it's a 1-line fix, I missed a point in the original article I was using for reference:
http://effbot.org/zone/simple-top-down-parsing.htm

Search for "To support the unary operators" for an explanation.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: Fix ! operator precedence in manifestparser's expression parser

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8378266 [details] [diff] [review]
Fix ! operator precedence in manifestparser's expression parser

Review of attachment 8378266 [details] [diff] [review]:
-----------------------------------------------------------------

thanks for the fix and the tests!!

Comment 3

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/758c586cde7a

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/758c586cde7a