Closed
Bug 974373
Opened 11 years ago
Closed 11 years ago
Odin: show a message when trying to log with parallel compile mode
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: bbouvier, Assigned: bbouvier)
References
()
Details
Attachments
(1 file)
1.37 KB,
patch
|
h4writer
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8378276 -
Flags: review?(hv1989)
Comment 1•11 years ago
|
||
Comment on attachment 8378276 [details] [diff] [review]
show-parallel-compile-odin.patch
Review of attachment 8378276 [details] [diff] [review]:
-----------------------------------------------------------------
Good to also log this :D
::: js/src/jit/AsmJS.cpp
@@ +5753,5 @@
> ParallelCompilationGuard g;
> if (!ParallelCompilationEnabled(m.cx()) || !g.claim())
> return CheckFunctionsSequential(m);
>
> + IonSpew(IonSpew_Logs, "Can't log asm.js script. (Compiled on background thread)");
Nit: Add a "." after "Compiled on ... thread." to have the same message for normal compilation and asm.js compilation
Attachment #8378276 -
Flags: review?(hv1989) → review+
Assignee | ||
Comment 2•11 years ago
|
||
Thanks for the quick review!
https://hg.mozilla.org/integration/mozilla-inbound/rev/9291178fcfd1
Comment 3•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•