Closed Bug 974373 Opened 11 years ago Closed 11 years ago

Odin: show a message when trying to log with parallel compile mode

Categories

(Core :: JavaScript Engine: JIT, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: bbouvier, Assigned: bbouvier)

References

()

Details

Attachments

(1 file)

No description provided.
Attachment #8378276 - Flags: review?(hv1989)
Comment on attachment 8378276 [details] [diff] [review] show-parallel-compile-odin.patch Review of attachment 8378276 [details] [diff] [review]: ----------------------------------------------------------------- Good to also log this :D ::: js/src/jit/AsmJS.cpp @@ +5753,5 @@ > ParallelCompilationGuard g; > if (!ParallelCompilationEnabled(m.cx()) || !g.claim()) > return CheckFunctionsSequential(m); > > + IonSpew(IonSpew_Logs, "Can't log asm.js script. (Compiled on background thread)"); Nit: Add a "." after "Compiled on ... thread." to have the same message for normal compilation and asm.js compilation
Attachment #8378276 - Flags: review?(hv1989) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: