974394 - Preferences: duplicated access key A used in Connection settings

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P5)

Description

[Francesco Lodolo [:flod]]

Currently "a" is used for both "Do not prompt for authentication if password is saved" (introduced in bug 910670) and "Automatic proxy configuration URL:".

Only "i" and "v" are available, personally I would choose "v" ("i" is never a good choice for access keys).

Comment 1

[Manish Goregaokar [:manishearth]]

I don't think we need an accesskey for the new "Do not prompt" pref, just added it for consistency. The pref is a one-time use thing, more or less. (The entire prefpane is like that, but this one is like that in particular)


But v would work if we want it.

Comment 2

[Manish Goregaokar [:manishearth]]

Attachment: Removing the accesskey

Comment 3

[Manish Goregaokar [:manishearth]]

Attachment: Changing to "v"

Comment 4

[Francesco Lodolo [:flod]]

I'm pretty sure removing the access key is an accessibility error. Having said that, if you remove the string you need to remove the reference in the XUL file as well.

Comment 5

[Manish Goregaokar [:manishearth]]

Comment on attachment 8378347 [details] [diff] [review]
Removing the accesskey

Drew, could you have a look at these and decide which one we should use? Thanks.

Comment 6

[Manish Goregaokar [:manishearth]]

Attachment: Removing the accesskey

Adding r=

Comment 7

[Manish Goregaokar [:manishearth]]

Attachment: Changing to "v"

Comment 8

[Francesco Lodolo [:flod]]

Comment on attachment 8378349 [details] [diff] [review]
Removing the accesskey

Even if it's r-, let's avoid possible confusions.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1f826ebee2b5

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1f826ebee2b5

Comment 11

[Bogdan Maris, Desktop QA]

Using latest Nightly in Ubuntu 13.04 Alt+V does nothing in Connection Settings panel. The access key is set to 'v' but it cannot be accessed via keyboard.

Comment 12

[Manish Goregaokar [:manishearth]]

Hmm, looks like alt-v partially works if you do it from the remote DNS thing


turns out that the accesskey "v" is already used for SOCKS v5.

Should we use i, or drop it entirely?

Comment 13

[Drew Willcoxon :adw]

Let's go with i.  Third time's the charm.

Comment 14

[Manish Goregaokar [:manishearth]]

Attachment: replace with i

Comment 15

[Drew Willcoxon :adw]

Comment on attachment 8383857 [details] [diff] [review]
replace with i

Review of attachment 8383857 [details] [diff] [review]:
-----------------------------------------------------------------

This patch doesn't apply cleanly because it still has "a" for the current accesskey, but the current accesskey is actually "v".  Please post a patch based on the current tree.

Comment 16

[Manish Goregaokar [:manishearth]]

Attachment: replace with i

Well, that was silly of me. Fixed.

Comment 17

[Drew Willcoxon :adw]

Comment on attachment 8383884 [details] [diff] [review]
replace with i

Review of attachment 8383884 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 18

[Manish Goregaokar [:manishearth]]

Tested, seems to work for me.

Comment 19

[Francesco Lodolo [:flod]]

(In reply to Manish Goregaokar [:manishearth] from comment #12)
> turns out that the accesskey "v" is already used for SOCKS v5.

Sorry about that, not sure how I missed it while checking for free accesskeys :-\

Comment 20

[Matthew N. [:MattN]]

https://hg.mozilla.org/integration/fx-team/rev/c543d5d38e29

Comment 21

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/c543d5d38e29