Closed Bug 974411 Opened 10 years ago Closed 10 years ago

js/comments.js::toggle_all_comments() shouldn't try to match non-comment elements

Categories

(Bugzilla :: Bugzilla-General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 5.0

People

(Reporter: glob, Assigned: glob)

References

Details

Attachments

(1 file)

from bmo bug 974393.

we're seeing javascript errors when collapsing comments via the tagging ui.  i've traced this to an interaction between an extension and toggle_all_comments()... we're adding elements with the bz_comment_text class which are confusing this function.
Attached patch 974411_1.patchSplinter Review
Attachment #8378330 - Flags: review?(gerv)
Comment on attachment 8378330 [details] [diff] [review]
974411_1.patch

Review of attachment 8378330 [details] [diff] [review]:
-----------------------------------------------------------------

r=gerv.

Gerv
Attachment #8378330 - Flags: review?(gerv) → review+
Flags: approval+
Target Milestone: --- → Bugzilla 5.0
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   3ef245b..ad9b149  master -> master
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: