Closed Bug 974498 Opened 6 years ago Closed 6 years ago

Refactor XPIProvider's private zip utilities into a ZipUtils.jsm

Categories

(Toolkit :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: janx, Assigned: janx)

References

Details

Attachments

(1 file, 5 obsolete files)

XPIProvider defines two generic zip extraction methods that, if exposed, could be reused elsewhere in the code base. They should be extracted into a new ZipUtils.jsm module.
Summary: Refactor XPIProvider's private zip utilities into a ZipUtils.jsm to make them reusable → Refactor XPIProvider's private zip utilities into a ZipUtils.jsm
Comment on attachment 8378436 [details] [diff] [review]
Refactor XPIProvider's private zip utilities into a ZipUtils.jsm to make them reusable.

Dave, care to take a look?
Attachment #8378436 - Flags: review?(dtownsend+bugmail)
Comment on attachment 8378436 [details] [diff] [review]
Refactor XPIProvider's private zip utilities into a ZipUtils.jsm to make them reusable.

Breaking this into its own module means we should probably have a few tests for it, separate from the add-ons manager stuff.
Attachment #8378436 - Flags: review?(dtownsend+bugmail) → review-
Component: File Handling → General
Product: Firefox → Toolkit
Attachment #8378436 - Attachment is obsolete: true
Comment on attachment 8387645 [details] [diff] [review]
Refactor XPIProvider's private zip utilities into a ZipUtils.jsm. r=Mossop

Rebased, fixed, added tests, ready for round #2.
Attachment #8387645 - Flags: review?(dtownsend+bugmail)
Comment on attachment 8387645 [details] [diff] [review]
Refactor XPIProvider's private zip utilities into a ZipUtils.jsm. r=Mossop

I'm assuming the code in the module is just a straight copy/paste with no other changes. If there are please flag them for me and ask for review again otherwise this is good to go.
Attachment #8387645 - Flags: review?(dtownsend+bugmail) → review+
Attached patch changes.diff (obsolete) — Splinter Review
Thanks for the review Dave! The move was mostly a straight cut & paste, but I had to modify a few minor things (function structure and logging). Flagging you on these changes just in case.
Attachment #8389119 - Flags: review?(dtownsend+bugmail)
Comment on attachment 8389119 [details] [diff] [review]
changes.diff

Review of attachment 8389119 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, looks good.
Attachment #8389119 - Flags: review?(dtownsend+bugmail) → review+
Keywords: checkin-needed
Comment on attachment 8389119 [details] [diff] [review]
changes.diff

Great, thanks Dave! Marking diff as obsolete to avoid confusions.
Attachment #8389119 - Attachment is obsolete: true
https://hg.mozilla.org/integration/fx-team/rev/b5fec3059a69
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/b5fec3059a69
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.