Closed Bug 974562 Opened 10 years ago Closed 10 years ago

nsSVGImageFrame class (declared in nsSVGImageFrame.cpp) needs some MOZ_OVERRIDE

Categories

(Core :: SVG, defect)

Product:
Core
Component:
SVG
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 974687

People

(Reporter: dholbert, Assigned: Six)

References

Details

As noted in bug 974135 comment 2, nsSVGImageFrame has some methods that should be labeled MOZ_OVERRIDE. At least the following, and I might've missed another one or two:
 GetFrameForPoint
 ReflowSVG
 AttributeChanged
 DestroyFrom
 GetType
 GetFrameName
I'll probably post a patch to fix this in the next week or so, if Arnaud doesn't get to it first.
Flags: needinfo?(dholbert)
i take it and will add .cpp files to the script i'm using
Assignee: nobody → six.dsn
Status: NEW → ASSIGNED
Flags: needinfo?(dholbert)
I prefer to wait that the patch for bug 974135 is landed on m-c as they have lines in common.
the script is ready to go.
Depends on: 974135
This bug will be fixed by bug 974687 which includes nsSVGImageFrame.cpp
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.