974606 - B2G RIL: Implement getCardLockRetryCount

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Vendcom, defect)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

Right now we do not support getCardLockRetryCount in MozRIL. But since we don't have access to QC's RIL anymore we need this method to test cert blocking bugs like bug 966571.

http://hg.mozilla.org/mozilla-central/file/9d4a66700c26/dom/system/gonk/ril_worker.js#l748

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Michael Henretty [:mhenretty] from comment #0)
> Right now we do not support getCardLockRetryCount in MozRIL. But since we
> don't have access to QC's RIL anymore we need this method to test cert
> blocking bugs like bug 966571.
> 
> http://hg.mozilla.org/mozilla-central/file/9d4a66700c26/dom/system/gonk/
> ril_worker.js#l748

RIL does implement getCardLockRetryCount. The problem you see in the above code is because the vendor modem doesn't support the request 'REQUEST_GET_UNLOCK_RETRY_COUNT.' And without vendor support, RIL cannot do anything.

Comment 2

[Jason Smith [:jsmith]]

(In reply to Hsin-Yi Tsai  [:hsinyi] from comment #1)
> (In reply to Michael Henretty [:mhenretty] from comment #0)
> > Right now we do not support getCardLockRetryCount in MozRIL. But since we
> > don't have access to QC's RIL anymore we need this method to test cert
> > blocking bugs like bug 966571.
> > 
> > http://hg.mozilla.org/mozilla-central/file/9d4a66700c26/dom/system/gonk/
> > ril_worker.js#l748
> 
> RIL does implement getCardLockRetryCount. The problem you see in the above
> code is because the vendor modem doesn't support the request
> 'REQUEST_GET_UNLOCK_RETRY_COUNT.' And without vendor support, RIL cannot do
> anything.

In other words - This is a vendor image problem (e.g. I would have to ask TCL to fix this in their base image)?

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Jason Smith [:jsmith] from comment #2)
> (In reply to Hsin-Yi Tsai  [:hsinyi] from comment #1)
> > (In reply to Michael Henretty [:mhenretty] from comment #0)
> > > Right now we do not support getCardLockRetryCount in MozRIL. But since we
> > > don't have access to QC's RIL anymore we need this method to test cert
> > > blocking bugs like bug 966571.
> > > 
> > > http://hg.mozilla.org/mozilla-central/file/9d4a66700c26/dom/system/gonk/
> > > ril_worker.js#l748
> > 
> > RIL does implement getCardLockRetryCount. The problem you see in the above
> > code is because the vendor modem doesn't support the request
> > 'REQUEST_GET_UNLOCK_RETRY_COUNT.' And without vendor support, RIL cannot do
> > anything.
> 
> In other words - This is a vendor image problem (e.g. I would have to ask
> TCL to fix this in their base image)?

Correct. We need them to help have the solution in their base image.

Comment 4

[Jason Smith [:jsmith]]

Okay - moving over to Vendcom then.

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

I saw this working today on flame 188 \o/