Closed Bug 974620 Opened 6 years ago Closed 3 years ago

tcanvasmark wastes time waiting after each scene

Categories

(Testing :: Talos, defect)

defect
Not set

Tracking

(firefox50 fixed)

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: vikstrous, Assigned: malayaleecoder)

References

Details

(Whiteboard: [talos_wishlist])

Attachments

(3 files)

When I ran the gecko profiler on tcanvasmark I noticed that the test waits 2 seconds after each scene before moving on to the next one. My best guess is that this is done so that when it's run manually the score for each test can be visually observed. This is not necessary when the test is run on Talos, so if nobody has a good reason to keep this 2 second delay I recommend that we remove it (or at least shorten it to something reasonable).

Right now this delay is applied 8x times per cycle and there are 5 cycles per test, so the total wasted time by this is 8*5*2 = 80 seconds per test.
Blocks: 1088251
Whiteboard: [talos_wishlist]
Assignee: nobody → malayaleecoder
Status: NEW → ASSIGNED
I guess this should solve the problem. It worked fine in my local machine :)
Attachment #8771858 - Flags: review?(jmaher)
are the numbers the same before/after when you run it locally?  note, they are not going to be 100% identical, but very similar?
Attached file before_patch.json
Attached file after_patch.json
I am attaching the local.json files before and after my patch.
Joel, please have a look at it :)
Flags: needinfo?(jmaher)
these numbers don't look too different!
Flags: needinfo?(jmaher)
Comment on attachment 8771858 [details] [diff] [review]
Bug974620_v1.diff

Review of attachment 8771858 [details] [diff] [review]:
-----------------------------------------------------------------

please run on try with try: -b o -p linux64,win32,win64,macosx -u none -t all
Attachment #8771858 - Flags: review?(jmaher) → review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d0cb076a4e73
tcanvasmark wastes time waiting after each scene. r=jmaher
https://hg.mozilla.org/mozilla-central/rev/d0cb076a4e73
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.