974637 - Enforce that all items have a URL

Status: RESOLVED DUPLICATE of bug 969055

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[:Margaret Leibovic]

Right now, we support dataset items without URLs, but when I click on an item without a URL, we load about:blank, which is not useful.

We either shouldn't do anything when the user clicks on one of these items, or we should enforce that a item has a URL.

I'm somewhat concerned about things looking broken if clicking doesn't do anything, so maybe we should enforce that all items have a URL.

Thoughts?

Comment 1

[Lucas Rocha (:lucasr)]

(In reply to :Margaret Leibovic from comment #0)
> Right now, we support dataset items without URLs, but when I click on an
> item without a URL, we load about:blank, which is not useful.
> 
> We either shouldn't do anything when the user clicks on one of these items,
> or we should enforce that a item has a URL.
> 
> I'm somewhat concerned about things looking broken if clicking doesn't do
> anything, so maybe we should enforce that all items have a URL.
> 
> Thoughts?

I'd go with enforcing URLs in the dataset. I can't think of any useful example for showing something in about:home that can't be clicked.

Comment 2

[Ian Barlow (:ibarlow)]

I was going to ask a related question: when / how might a situation like this occur?

Comment 3

[Ian Barlow (:ibarlow)]

I like Lucas's idea of enforcing URLs. Either that or if we can't do that, don't do anything when a user taps something with no URL -- don't even show a touch highlight.

Comment 4

[:Margaret Leibovic]

(In reply to Ian Barlow (:ibarlow) from comment #2)
> I was going to ask a related question: when / how might a situation like
> this occur?

Right now this can happen if an add-on stores an item without a URL, since we don't enforce that.

I like enforcing URLs, that's the simplest solution.

Comment 5

[:Margaret Leibovic]

Duping to bug 969055.