974690 - NS_DebugBreak not printing NS_DEBUG_ASSERTION to TBPL-readable logs on Android

Status: NEW

(Core :: XPCOM, defect)

Description

[Kelsey Gilbert [:jgilbert]]

I'm investigating mochitest-gl is orange on Android+DEBUG. The only issue on ceder was this line:

529 ERROR TEST-UNEXPECTED-FAIL | /tests/content/canvas/test/webgl/test_webgl_conformance_test_suite.html | Assertion count 2 is greater than expected range 0-0 assertions.

From reading xpcom/base/nsDebugImpl, it looks like all assertions that pass through NS_DebugBreak should be logged with a "###!!! ASSERTION" prefix, but the 'full log' from TBPL didn't include any such lines.

I wrote a hacky patch to record these lines, and dump them to printf_stderr when nsDebugImpl::GetAssertionCount() is called, and pushed it to Ceder. This gave me the following output:

14:47:02     INFO -  02-19 14:46:48.226 I/Gecko   ( 2228): ###AssertRecord: [2228] ###!!! ASSERTION: Network state should be loading: `mNetworkState == nsIDOMHTMLMediaElement::NETWORK_LOADING`, in /builds/slave/ced-and-d-00000000000000000000/build/content/html/content/src/HTMLMediaElement.cpp:936
14:47:02     INFO -  02-19 14:46:48.226 I/Gecko   ( 2228): ###AssertRecord: [2228] ###!!! ASSERTION: Network state should be loading: `mNetworkState == nsIDOMHTMLMediaElement::NETWORK_LOADING`, in /builds/slave/ced-and-d-00000000000000000000/build/content/html/content/src/HTMLMediaElement.cpp:936
14:47:02     INFO -  02-19 14:46:48.226 I/GeckoDump( 2228): 529 ERROR TEST-UNEXPECTED-FAIL | /tests/content/canvas/test/webgl/test_webgl_conformance_test_suite.html | Assertion count 2 is greater than expected range 0-0 assertions.

Why weren't these in the normal TBPL output?

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: hacky patch for dumping invisible asserts

Here's the hacky patch I used to record and dump this stuff. It's really unsafe, but it helped me out.