974798 - Document Converter fails decompression with apktool in stage (wrong S3 bucket for APKs)

Status: VERIFIED FIXED

(Marketplace Graveyard :: Integration, defect)

Description

[Austin King [:ozten]]

I think the authentication between the factory and the signer have changed or their is a server time mismatch.

    export MANI=http://doc2any.grapph.com/doc2any/doc2any.webapp
    curl "https://apk-controller.stage.mozaws.net/application.apk?manifestUrl=${MANI}"
        Error in generator - {
      "status": "error",
      "message": "SIGNER_REFUSED_REQUEST"
    }

Cached APKs come back fine, so a manifest url which is not in the cache should be used to reproduce.

Comment 1

[Jason Thomas [:jason]]

I noticed this issue when standing up -dev last night. 

It looks like apk-signer is trying to use the 'key' bucket instead of the 'public' bucket to locate the unsigned APK:
<?xml version="1.0" encoding="UTF-8"?>#012<ListBucketResult xmlns="http://s3.amazonaws.com/doc/2006-03-01/"><Name>net.mozaws.stage.apk.key</Name><Prefix></Prefix><Marker></Marker><MaxKeys>0</MaxKeys><IsTruncated>false</IsTruncated></ListBucketResult>; :/opt/apk-signer/apk-signer/venv/lib/python2.6/site-packages/boto/s3/bucket.py:379
calculating payload hash from:#012['hawk.1.payload\n',#012 'application/json\n',#012 '{"error": {"unsigned_apk_s3_path": ["unsigned APK key Calculator-release-unsigned.apk does not exist on S3"]}}',#012 '\n'] :/opt/apk-signer/apk-signer/venv/lib/python2.6/site-packages/mohawk/util.py:50

Comment 2

[Jason Thomas [:jason]]

For testing purposes on -dev I set S3_KEY_BUCKET to S3_APK_BUCKET and this started to work again.

Comment 3

[Kumar McMillan [:kumar]]

Thanks for the info, Jason. That was indeed the bug!

Fixed: https://github.com/mozilla/apk-signer/commit/d2bd2b125881ee109cc88efe8f98473b4f436100

Comment 4

[Victor Carciu]

Can you please add some specific STRs to this bug or mark it as [qa-] ?

Comment 5

[Kumar McMillan [:kumar]]

wouldn't hurt to get some QA but not a big deal.

STR
- open Firefox on your Android device
- Go to about:config
- search for apk
- Change browser.webapps.apkFactoryUrl to https://apk-controller.dev.mozaws.net/application.apk
- install a webapp that has never been installed before (i.e. generate a unique manifest URL first)

Expected: the APK should install on your Android device without errors

I tried the controller directly (which is only a partial test), like this:

curl --insecure -v 'https://apk-controller.dev.mozaws.net/application.apk?manifestUrl=http://eland2583.testmanifest.com/manifest.webapp'

Comment 6

[Austin King [:ozten]]

Awesome, doc2any on stage looking good to apktool.jar and jarsigner verify.

Thanks Jason and Kumar!

Comment 7

[Victor Carciu]

Verified as fixed .

Please note that the bug is fixed only for stage now using https://apk-controller.stage.mozaws.net/application.apk