974809 - Using travis_fold for reading log easily

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia, defect)

Description

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

we can add specific line in output to fold some part of log for reading easily, for example:

> travis_fold:start:notices
> ...folded log
> travis_fold:end:notices

here is an example to do that:

https://travis-ci.org/macbre/travis-fold/builds/15440997
https://s3.amazonaws.com/archive.travis-ci.org/jobs/15440998/log.txt

Comment 1

[Ram Dayal Vaishnav [:ram]]

Hi Yuren, can you please be more descriptive about what is to be done? If I get it, then I would like to fix this bug :)

Comment 2

[Mike Hoye [:mhoye]]

Hi, Ram - Are you still interested in pursuing this?

Comment 3

[Ram Dayal Vaishnav [:ram]]

Yes Mike :)

Comment 4

[Vikas S Yaligar]

Hey ! I am new in here and interested in working on this, can you specify what exactly to fold.

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Hi Vikas,

accroding current log, mostly build logs comes from makefile rule "app" on line 510[1], so we can start from there, it means we can print "travis_fold:start:app" and "travis_fold:end:app" in build/app.js if environment variable TRAVIS=true

to get environment variable in gaia build system, you can use utils.getEnv('TRAVIS') and use |dump()| to print the message and test by |TRAVIS=true make|

needinfo me if you have any question!

[1] https://github.com/mozilla-b2g/gaia/blob/8d051e3b074fd37674d0152f27761c39b54f4114/Makefile#L510-L511

Comment 6

[Vikas S Yaligar]

Attachment: travis_fold in app.js

I have sent you a patch. Would be happy if you can comment on it

Comment 7

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

looks good and I trigger a build on travis

https://travis-ci.org/yurenju/gaia/builds/33466621

this pull request will will be r+ if the result is expected as we think. thanks!

Comment 8

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8478107 [details] [review]
travis_fold in app.js

Vikas, 

|dump("travis_fold:start:end\n");| should be |dump("travis_fold:end:app\n");|

please modify it and send me review again

Comment 9

[Vikas S Yaligar]

Comment on attachment 8478107 [details] [review]
travis_fold in app.js

>https://github.com/mozilla-b2g/gaia/pull/23257

Comment 10

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

trigger again.

https://travis-ci.org/yurenju/gaia/builds/33552118

Comment 11

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8478107 [details] [review]
travis_fold in app.js

before:
https://travis-ci.org/mozilla-b2g/gaia/jobs/33558738

after:
https://travis-ci.org/yurenju/gaia/jobs/33552121

looks clearer! but gaia tree now is closed, I will land this pull request when it open again. thanks for your contribution!

Comment 12

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

and please remove "WIP" in your commit message.

Comment 13

[Vikas S Yaligar]

Updated the commit message. Thank you

Comment 14

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Vikas, please use single quotes in your commit, that is last nit! sorry I didn't notice before. you also can use |jshint| to check lint error for the file you modified.

Comment 15

[Vikas S Yaligar]

OK ! I have done that, but when I run `jslint build/app.js`, I also get following errors => 

 #3 Expected 'if' at column 5, not column 3.
    if (utils.getEnv('TRAVIS')) { // Line 9, Pos 3

 #4 Expected 'dump' at column 9, not column 5.
    dump('travis_fold:start:app\n'); // Line 10, Pos 5

and other errors of the code which I have not touched. Could you please tell me why is that happening?

Comment 16

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

because dump is a global function from js runtime, so you need add it on line 3 comment:

/* global exports, require, dump */

Comment 17

[Vikas S Yaligar]

Ok I have updated the commit. But there is no change in output by jslint.

Comment 18

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

merged, thanks for your contribution!

https://github.com/mozilla-b2g/gaia/commit/7be54506620452e3f9b5cef9dcfa09af171ded58

Comment 19

[Kevin Grandon :kgrandon]

Backed out for causing failures on gaia-try and travis like:

1) app.js BUILD_APP_NAME = *:

TypeError: Object #<Object> has no method 'getEnv'

at Object.exports.execute (/home/travis/build/mozilla-b2g/gaia/build/app.js:9:13)

at Context.<anonymous> (/home/travis/build/mozilla-b2g/gaia/build/test/unit/app.test.js:43:9)

at callFn (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:223:21)

at Test.Runnable.run (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:216:7)

at Runner.runTest (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:373:10)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:451:12

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:298:14)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:308:7

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:246:23)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:270:7

at done (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:185:5)

at callFn (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:228:7)

at Hook.Runnable.run (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:216:7)

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:258:10)

at Object._onImmediate (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:275:5)

at processImmediate [as _immediateCallback] (timers.js:336:15)

2) app.js BUILD_APP_NAME = app1:

TypeError: Object #<Object> has no method 'getEnv'

at Object.exports.execute (/home/travis/build/mozilla-b2g/gaia/build/app.js:9:13)

at Context.<anonymous> (/home/travis/build/mozilla-b2g/gaia/build/test/unit/app.test.js:60:9)

at callFn (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:223:21)

at Test.Runnable.run (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:216:7)

at Runner.runTest (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:373:10)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:451:12

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:298:14)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:308:7

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:246:23)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:270:7

at done (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:185:5)

at callFn (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:228:7)

at Hook.Runnable.run (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:216:7)

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:258:10)

at Object._onImmediate (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:275:5)

at processImmediate [as _immediateCallback] (timers.js:336:15)



https://github.com/mozilla-b2g/gaia/commit/8c0be26ed3668d9061e75af1c80087c681cc5e13


Vikas - would you be able to help us fix these test issues?

Comment 20

[Mike Hoye [:mhoye]]

Hi, Vikas - You're very close to getting this one over the line. Are you still interested in working on it?

Thanks,

- mhoye

Comment 21

[Vikas S Yaligar]

Ah ! ya just got busy with my classwork. i will look into it within this weekend. Thank you

Comment 22

[Vikas S Yaligar]

ok ! I am back now(as I am done with my exams).

Kevin, I was not able to reproduce it. Can you please let me know which command to execute(sorry I am a newbie), as normal make works fine for me.

Thank you

Comment 23

[Kevin Grandon :kgrandon]

(In reply to Vikas S Yaligar from comment #22)
> ok ! I am back now(as I am done with my exams).
> 
> Kevin, I was not able to reproduce it. Can you please let me know which
> command to execute(sorry I am a newbie), as normal make works fine for me.
> 
> Thank you

Have you tried running the build unit tests? You can do so with something like, `make build-test-unit`.

Comment 24

[BMO Automation]

Firefox OS is not being worked on