974816 - right click in the calendar list bring up wrong calendar property dialog after toggle offline

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Chen Wei]

Attachment: fix right click bring up wrong calendar property dialog

Reproducible: Always

Steps to Reproduce:
Right click on a network calendar, in the properties dialog, toggle offline mode, accept change, then right click the same calendar again, open the properties dialog, this time the dialog shows properties of the calendar below, unless it right clicked calendar is the last one.


patch:
right click a calendar in calendar tree will assign it to compositeCalendar.defaultCalendar, if right click that calendar again without click another calendar, the  compositeCalendar.defaultCalendar is unchanged. It is normally okay until toggle calendar offline status from the right click => properties  dialog, the offline toggling remove old one, assign next calendar to compositeCalendar.defaultCalendar, and does not assign the newly created cached/uncached calendar to  compositeCalendar.defaultCalendar after done. The next time right click on calendar will bring up the properties dialog of the calendar below it, unless it is the last one in the tree view.

Comment 2

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Comment on attachment 8378866 [details] [diff] [review]
fix right click bring up wrong calendar property dialog

Looks good, r=philipp

Comment 3

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Comment on attachment 8378866 [details] [diff] [review]
fix right click bring up wrong calendar property dialog

Review of attachment 8378866 [details] [diff] [review]:
-----------------------------------------------------------------

::: calendar/base/content/widgets/calendar-list-tree.xml
@@ +499,5 @@
> +                composite.defaultCalendar.id !=
> +                      this.getCalendar(this.tree.currentIndex).id) {
> +              composite.defaultCalendar = this.getCalendar(
> +                                                        this.tree.currentIndex);
> +              }

Actually, these lines could be split up a bit with local variables, and it looks like there are some minor whitespace issues. I'll fix this before checkin.

Comment 4

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Attachment: Fix - v2

Here is the patch for checkin

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/74fed8c5ce2d