974828 - [DSDS][Settings] Outgoing data confirmation is shown in the back layer(visible) when selection is not yet tapped

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Eric Chang [:ericcc] [:echang]]

Fugu/2 SIM inserted
Build 2014/02/20 v1.4

1. Open "Sim manager" in "Settings".
2. Change default SIM for Data to another one.
3. Before tapping "OK", leave screen in SIM selection.
4. <ISSUE> Suspended Confirmation is also show in background.

(Pdb) m = self.marionette
(Pdb) m.find_elements('css selector', 'button.modal-dialog-confirm-ok')[0].is_displayed()
True
(Pdb) qq = m.find_elements('css selector', 'button.modal-dialog-confirm-ok')[0]
(Pdb) qq.location
{u'y': 516.3333129882812, u'x': 165}

Comment 1

[Eric Chang [:ericcc] [:echang]]

Attachment: You can see the text in the middle of the screen... "The current data transfer will be suspended. Continue anyway?"

Comment 2

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Good catch !

I would take this bug !

Thanks Eric.

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8379634 [details] [review]
patch

Arthur, I put the r? flag on you first. Please help me review this part when your schedule is not so tight ! Thanks !

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8379634 [details] [review]
patch

r=me with the comments addressed, thanks!

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Merged in Gaia/bubble-tea : 6dbf7776373b0b239b0e67cc9b242855c2975a15 

Thanks all !

Comment 7

[[e-mail]]

merged to master https://github.com/gasolin/gaia/commit/e592ec99013a43002171d1bd4be2f497c12ada88

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Reverted in https://github.com/mozilla-b2g/gaia/commit/3aa80386e098a2a83ca9e0e4c277cf3536541d9e because something in this or one of the six other patches that the b2g bumper bot included in a single push to b2g-inbound broke gaia-ui tests on TBPL:

bumper bot's push's contents: https://hg.mozilla.org/integration/b2g-inbound/rev/0c2938cd910b
The gaia-ui failure: https://tbpl.mozilla.org/php/getParsedLog.php?id=36421229&tree=B2g-Inbound


In the future, can we please not merge seven patches in the course of 5 minutes? It would make tracking down regressions much simpler if they were spaced several minutes apart each.

Comment 9

[[e-mail]]

create the PR and travis all green https://github.com/mozilla-b2g/gaia/pull/17364 
will land once gaia repo open

Comment 10

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Fred Lin [:gasolin] from comment #9)
> create the PR and travis all green
> https://github.com/mozilla-b2g/gaia/pull/17364 
> will land once gaia repo open

Thanks Fred !!

Comment 11

[[e-mail]]

merged https://github.com/mozilla-b2g/gaia/commit/0eb7e0f181411ba8d70c4ff24c703ee6ee43de8a

Comment 12

[Eric Chang [:ericcc] [:echang]]

GAIA_REV=730670951e40b2317a167fcd07c398bb662d6e87
GECKO_REV=ce6783cbe8ffeaea447ac7a5b9b11c2c4881f194
GAIA_BRANCH=mozillaorg/v1.4
GECKO_BRANCH=mozillaorg/v1.4
BUILD_TAG=jenkins-B2G.v1.4.0.fugu-4
BuildID=20140324140010

2g/gaia/tests/python/gaia-ui-tests/gaiatest/apps/settings/regions/sim_manager.py(44)select_and_confirm()
-> li = self.wait_for_element_present(*_list_item_locator)
(Pdb) m = self.marionette
(Pdb) m.find_elements('css selector', 'button.modal-dialog-confirm-ok')[0].is_displayed()
*** IndexError: list index out of range
(Pdb) qq = m.find_elements('css selector', 'button.modal-dialog-confirm-ok')[0]
*** IndexError: list index out of range
(Pdb)

Comment 14

[Arthur Chen [:arthurcc][inactive after 6/30]]

Nominate for v1.3T+ as the duplicate of this bug is v1.3T blocker.

Comment 15

[Joe Cheng [:jcheng] (please needinfo)]

1.3T+, please fix it in 1.3T, thanks

Comment 16

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: PR for v1.3

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): DSDS
[User impact] if declined: Poor user experience
[Testing completed]: Manual tests and unit tests.
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: N/A

Comment 17

[bhavana bajaj [:bajaj]]

Arthur, this cannot be approved for 1.3 as this is not blocking-b2g:1.3+ and we are landing only critical patches on 1.3 at this time.

Keeping in mind this is needed 1.3T, we can uplift this to 1.4 given we are still granting approvals their.

Can you confirm your patcha pplies to the 1.4 and 1.3T branch cleanly?

Comment 18

[bhavana bajaj [:bajaj]]

Comment on attachment 8399476 [details]
PR for v1.3

clearing the approval for 1.3 and switching to 1.4.

Before approving waiting for arthur to confirm the attached patch applies for 1.4 and 1.3T.

Comment 19

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: PR for v1.3T

Comment 20

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: PR for v1.4

Comment 21

[Arthur Chen [:arthurcc][inactive after 6/30]]

The patch can be applied to 1.4 and 1.3T cleanly. Can I merge to v1.3T without approval?

Comment 22

[bhavana bajaj [:bajaj]]

(In reply to Arthur Chen [:arthurcc] from comment #21)
> The patch can be applied to 1.4 and 1.3T cleanly. Can I merge to v1.3T
> without approval?

yes, please.

Comment 23

[bhavana bajaj [:bajaj]]

Comment on attachment 8400353 [details]
PR for v1.4

a=bajaj to land this on 1.4

Comment 24

[Arthur Chen [:arthurcc][inactive after 6/30]]

v1.3t: 5b8e322b2740c74a7663a13d215a114ee548b886
v1.4 : 1db7a4857faec427799de0827964128b445e80ea