Closed Bug 974830 Opened 6 years ago Closed 6 years ago

Expose MOZ_APP_DISPLAYNAME in application.ini if it differs from MOZ_APP_BASENAME

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox29 fixed, firefox30 verified)

VERIFIED FIXED
mozilla30
Tracking Status
firefox29 --- fixed
firefox30 --- verified

People

(Reporter: glandium, Assigned: glandium)

References

Details

(Whiteboard: [qa-automation-blocked][mozmill])

Attachments

(1 file)

Blocks: 972872
This is a feature our QA automation needs to be able to set Firefox as default browser for Metro tests on Windows 8.1. This is a blocker for us in Nightly and Aurora builds, where the brand name differs from the application name.
Whiteboard: [qa-automation-blocked][mozmill]
Attachment #8378897 - Flags: review?(benjamin) → review+
Whiteboard: [qa-automation-blocked][mozmill] → [qa-automation-blocked][mozmill][checkin-needed]
https://hg.mozilla.org/integration/mozilla-inbound/rev/673a7e313372
Whiteboard: [qa-automation-blocked][mozmill][checkin-needed] → [qa-automation-blocked][mozmill]
https://hg.mozilla.org/mozilla-central/rev/673a7e313372
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
We verified that it works fine with the appropriate build from inbound. Mike, would you mind to request approval for aurora? Thanks.
Status: RESOLVED → VERIFIED
Comment on attachment 8378897 [details] [diff] [review]
Expose MOZ_APP_DISPLAYNAME in application.ini if it differs from MOZ_APP_BASENAME

[Approval Request Comment]
User impact if declined: Required for QA. See bug 972872
Testing completed (on m-c, etc.): Tested on m-c. See comment 5
Risk to taking this patch (and alternatives if risky): None. This only adds extra info to aurora and nightly builds. Not beta or release. The extra info is added to application.ini, which is not used by firefox at runtime (it's only used by automation at this point). The derived data that *is* used by firefox ignores unknown fields, and the extra info *is* an unknown field.
String or IDL/UUID changes made by this patch: None
Attachment #8378897 - Flags: approval-mozilla-aurora?
Attachment #8378897 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.