Closed Bug 974845 Opened 6 years ago Closed 6 years ago
Fix libvpx compilation on mingw
Since last libvpx import, there is a problem on mingw, which uses VS version of config file containing incompatible INLINE define. A few other config value are also not accurate, but don't cause a problem. To fix that in a clean way, I had to change update.py to add the whole set of config files for mingw.
Attachment #8378925 - Flags: review?(j)
I also need this patch for mingw compilation. It's already upstreamed: https://gerrit.chromium.org/gerrit/#/c/68782/ I'm not sure how do we proceed here in this case. Can we just commit it or would that require a new patch file in the tree (that woule be obsolete after the next import).
(In reply to Jacek Caban from comment #1) > I'm not sure how do we proceed here in this case. Can we just commit it or > would that require a new patch file in the tree (that woule be obsolete > after the next import). the right thing would be to add the patch to the repository, add it to apply_patches() in update.py and apply the patch.
Thanks for quick reviews. This version adds a patch file.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.