Closed Bug 974845 Opened 6 years ago Closed 6 years ago

Fix libvpx compilation on mingw.

Categories

(Core :: Audio/Video, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: jacek, Assigned: jacek)

Details

Attachments

(2 files, 1 obsolete file)

Since last libvpx import, there is a problem on mingw, which uses VS version of config file containing incompatible INLINE define. A few other config value are also not accurate, but don't cause a problem. To fix that in a clean way, I had to change update.py to add the whole set of config files for mingw.
Attachment #8378925 - Flags: review?(j)
I also need this patch for mingw compilation. It's already upstreamed:

https://gerrit.chromium.org/gerrit/#/c/68782/

I'm not sure how do we proceed here in this case. Can we just commit it or would that require a new patch file in the tree (that woule be obsolete after the next import).
Flags: needinfo?(j)
(In reply to Jacek Caban from comment #1)
> I'm not sure how do we proceed here in this case. Can we just commit it or
> would that require a new patch file in the tree (that woule be obsolete
> after the next import).

the right thing would be to add the patch to the repository,
add it to apply_patches() in update.py and apply the patch.
Flags: needinfo?(j)
Attachment #8378925 - Flags: review?(j) → review+
Thanks for quick reviews. This version adds a patch file.
Attachment #8378926 - Attachment is obsolete: true
Attachment #8378934 - Flags: review?(j)
Attachment #8378934 - Flags: review?(j) → review+
https://hg.mozilla.org/mozilla-central/rev/1ed1c0688bbd
https://hg.mozilla.org/mozilla-central/rev/62a6b1b8d6fa
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.