Closed Bug 974859 Opened 10 years ago Closed 9 years ago

controller.waitForPageLoad() doesn't timeout for 0

Categories

(Testing Graveyard :: Mozmill, defect)

Product:
Testing Graveyard
Component:
Mozmill
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: whimboo, Unassigned, Mentored)

References

(
URL
)

Details

As what I have seen today while working on bug 957973 is that we do not timeout for waitForPageLoad(0) calls:

  try {
    controller.open(TEST_DATA[0].url);
    controller.waitForPageLoad(0);

    throw new Error("controller.waitForPageLoad() not timed out for timeout=0.");
  } catch (ex if ex instanceof errors.TimeoutError) {
  }

This should not raise an exception but it does right now. This was hidden because we haven't had the instanceof condition before.

Most likely nothing for 2.0.6 but we should get this investigated and fixed for 2.1.
URL: https://wiki.mozilla.org/Auto-tools/P...
Whiteboard: [mozmill-2.1?] → [mozmill-2.1?][mentor=whimboo][lang=js]
Whiteboard: [mozmill-2.1?][mentor=whimboo][lang=js] → [mozmill-2.1?][mentor=whimboo][lang=js][good first bug]
waitForPageLoad() code is hard to get into and fragile. So I explicitly haven't put good first bug on it.
Whiteboard: [mozmill-2.1?][mentor=whimboo][lang=js][good first bug] → [mozmill-2.1?][mentor=whimboo][lang=js]
Mentor: hskupin
Whiteboard: [mozmill-2.1?][mentor=whimboo][lang=js] → [mozmill-2.1?][lang=js]
Mozmill will reach its end of life soon. We are currently working on getting all the tests for Firefox ported to Marionette. For status updates please see bug 1080766.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
Whiteboard: [mozmill-2.1?][lang=js]
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.