nsCJVMManagerFactory.cpp contains unused obsolete code

VERIFIED FIXED in mozilla0.9.5

Status

P2
normal
VERIFIED FIXED
18 years ago
8 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

Trunk
mozilla0.9.5
x86
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

nsCJVMManagerFactory.cpp contains a lot of unused (in the #else of an #if 1),
obsolete, code.  This should be removed to make it easier for people to
understand what the file does, and to reduce the amount of code people have to
download.  (It took me a minute or two to notice that 90% of the file was unused.)

I'll attach a patch that does this.

Ed Burns, could you review?

Comment 2

18 years ago
ra=edburns IF you put in a comment in the .cpp file saying that in CVS version 
1.17 of this file, there was a lot of ifdef'd out code.  
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → mozilla0.9.5

Comment 3

18 years ago
Comment on attachment 47526 [details] [diff] [review]
patch

sr=waterson
Attachment #47526 - Flags: superreview+
I just noticed that nsCJVMManagerFactory.h can be cvs removed, since it's not
needed at all anymore.  I'll attach a new patch.

Updated

18 years ago
Attachment #48923 - Flags: review+
Attachment #48923 - Flags: approval+

Comment 6

18 years ago
Comment on attachment 48923 [details] [diff] [review]
revised patch

sr=waterson
Attachment #48923 - Flags: superreview+
Checked in 2001-09-10 17:42 PDT.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 8

17 years ago
Verified the patch.
Status: RESOLVED → VERIFIED

Updated

8 years ago
Component: Java: OJI → Java: OJI
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.