Closed
Bug 97491
Opened 23 years ago
Closed 23 years ago
nsCJVMManagerFactory.cpp contains unused obsolete code
Categories
(Core Graveyard :: Java: OJI, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.5
People
(Reporter: dbaron, Assigned: dbaron)
Details
Attachments
(2 files)
5.23 KB,
patch
|
waterson
:
superreview+
|
Details | Diff | Splinter Review |
7.40 KB,
patch
|
edburns
:
review+
waterson
:
superreview+
edburns
:
approval+
|
Details | Diff | Splinter Review |
nsCJVMManagerFactory.cpp contains a lot of unused (in the #else of an #if 1), obsolete, code. This should be removed to make it easier for people to understand what the file does, and to reduce the amount of code people have to download. (It took me a minute or two to notice that 90% of the file was unused.) I'll attach a patch that does this. Ed Burns, could you review?
Assignee | ||
Comment 1•23 years ago
|
||
ra=edburns IF you put in a comment in the .cpp file saying that in CVS version 1.17 of this file, there was a lot of ifdef'd out code.
Assignee | ||
Updated•23 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → mozilla0.9.5
Comment 3•23 years ago
|
||
Comment on attachment 47526 [details] [diff] [review] patch sr=waterson
Attachment #47526 -
Flags: superreview+
Assignee | ||
Comment 4•23 years ago
|
||
I just noticed that nsCJVMManagerFactory.h can be cvs removed, since it's not needed at all anymore. I'll attach a new patch.
Assignee | ||
Comment 5•23 years ago
|
||
Attachment #48923 -
Flags: review+
Attachment #48923 -
Flags: approval+
Comment 6•23 years ago
|
||
Comment on attachment 48923 [details] [diff] [review] revised patch sr=waterson
Attachment #48923 -
Flags: superreview+
Assignee | ||
Comment 7•23 years ago
|
||
Checked in 2001-09-10 17:42 PDT.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•