nsCJVMManagerFactory.cpp contains a lot of unused (in the #else of an #if 1), obsolete, code. This should be removed to make it easier for people to understand what the file does, and to reduce the amount of code people have to download. (It took me a minute or two to notice that 90% of the file was unused.) I'll attach a patch that does this. Ed Burns, could you review?
ra=edburns IF you put in a comment in the .cpp file saying that in CVS version 1.17 of this file, there was a lot of ifdef'd out code.
David Baron :dbaron: 🏴 ⌚UTC-8 (if account gets disabled due to email bounces, ask a bugzilla admin to reenable it)(Assignee)
18 years ago
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → mozilla0.9.5
Comment on attachment 47526 [details] [diff] [review] patch sr=waterson
Attachment #47526 - Flags: superreview+
I just noticed that nsCJVMManagerFactory.h can be cvs removed, since it's not needed at all anymore. I'll attach a new patch.
Comment on attachment 48923 [details] [diff] [review] revised patch sr=waterson
Attachment #48923 - Flags: superreview+
Checked in 2001-09-10 17:42 PDT.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
Verified the patch.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.