Closed
Bug 974916
Opened 12 years ago
Closed 12 years ago
Homepage feature images should fit screen width on widescreens
Categories
(Webmaker Graveyard :: webmaker.org, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: cassie, Assigned: kate)
Details
(Whiteboard: [homepage])
Attachments
(1 file)
Seems janky that color bars appear on the sides of the feature image on large screens. Can we make it fill the entire width of the screen? Would be interesting to look at how http://thegreatdiscontent.com/ and https://medium.com/ handle this.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #8396044 -
Flags: review?(gavin)
|
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8396044 [details] [review]
https://github.com/mozilla/webmaker.org/pull/651
Pretty close, just needs some tweaks for preloading. I put a patch in the GH comments.
Attachment #8396044 -
Flags: review?(gavin) → review-
|
|
Assignee | |
Updated•12 years ago
|
Attachment #8396044 -
Flags: review- → review?(gavin)
|
|
||
Updated•12 years ago
|
Attachment #8396044 -
Flags: review?(gavin) → review+
|
||
Comment 3•12 years ago
|
||
Commit pushed to master at https://github.com/mozilla/webmaker.org
https://github.com/mozilla/webmaker.org/commit/0941bf58cd2fafb35f0cdcf938309f27d886b46c
Fix bug 974916 - Make carousel images stretch to the entire page width
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•