Closed Bug 974966 Opened 10 years ago Closed 10 years ago

keyboard dismiss method is buggy

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Other
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: zcampbell, Assigned: zcampbell)

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
Bebe
: review+
Details | Review
Sometimes the keyboard can be hidden even when data-transition-in and data-transition-out are both True. this causes the dismiss() method to timeout.

I am not sure but perhaps we are dismissing the keyboard before it has fully transitioned and thus the attributes are not set correctly.

Perhaps it would be more reliable to just use "hide" in class and not is_displayed()


Here is an HTML source of it after it is stuck:

      <!-- keyboard -->
      <div data-z-index-level="keyboards" class="hide" id="keyboards" data-transition-in="true" data-transition-out="true"><iframe src="app://keyboard.gaiamobile.org/index.html#en" mozapptype="inputmethod" mozbrowser="true" mozpasspointerevents="true" mozapp="app://keyboard.gaiamobile.org/manifest.webapp" data-frame-name="en" data-frame-manifest-u-r-l="app://keyboard.gaiamobile.org/manifest.webapp" data-frame-path="/index.html#en"></iframe></div>
Assignee: nobody → zcampbell
Attached file github pr
Attachment #8379727 - Flags: review?(robert.chira)
Attachment #8379727 - Flags: review?(florin.strugariu)
Attachment #8379727 - Flags: review?(florin.strugariu) → review+
https://github.com/mozilla-b2g/gaia/commit/90888791941ff29cdc3a24c567575991dd0922a9
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Attachment #8379727 - Flags: review?(robert.chira)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: