Closed
Bug 975013
Opened 10 years ago
Closed 10 years ago
"Show" button in password field is too narrow for localized text
Categories
(Firefox for Android Graveyard :: Android Sync, defect)
Tracking
(firefox28 unaffected, firefox29 wontfix, firefox30 wontfix, firefox31 verified)
VERIFIED
FIXED
Firefox 31
Tracking | Status | |
---|---|---|
firefox28 | --- | unaffected |
firefox29 | --- | wontfix |
firefox30 | --- | wontfix |
firefox31 | --- | verified |
People
(Reporter: flod, Assigned: nalexander)
References
Details
Attachments
(1 file)
95.94 KB,
image/png
|
Details |
Similar to bug 962622, but I'm seeing this on my Nexus 7 with Android 4.4.2 Button width is basically tailored on the English string, and it will never work for localization.
Assignee | ||
Comment 1•10 years ago
|
||
It's possible I've fixed the button width. We can certainly make it fit the localized string, but we are assuming that the string is short. Perhaps we should add a localization note. jgruen?
Flags: needinfo?(jgruen)
Reporter | ||
Comment 2•10 years ago
|
||
(In reply to Nick Alexander :nalexander from comment #1) > It's possible I've fixed the button width. We can certainly make it fit the > localized string, but we are assuming that the string is short. Perhaps we > should add a localization note. jgruen? Define short. IMO you shouldn't really do assumptions on the length of a string. It's not the same string, but it says "Show", just to give you an idea http://transvision.mozfr.org/string/?entity=mobile/android/base/android_strings.dtd:pref_panels_show&repo=aurora
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #2) > (In reply to Nick Alexander :nalexander from comment #1) > > It's possible I've fixed the button width. We can certainly make it fit the > > localized string, but we are assuming that the string is short. Perhaps we > > should add a localization note. jgruen? > > Define short. IMO you shouldn't really do assumptions on the length of a > string. This is too coarse. Somehow operating systems manage to make horizontal menus at the top of windows "work" across languages, and we can find a way to horizontally juxtapose UX elements. In this case, the UX assumes that you can enter a password and display a button with a label beside it. If this isn't a valid assumption in this case, let's surface it to UX. If it's never a valid assumption, we have some significant changes to make, and we need to start discussing them.
Reporter | ||
Comment 4•10 years ago
|
||
(In reply to Nick Alexander :nalexander from comment #3) > In this case, the UX assumes that you can enter a password and display a > button with a label beside it. If this isn't a valid assumption in this > case, let's surface it to UX. Personally I think this is not a valid assumption, even if we're willing to accept some compromises. While I believe this UX could work as a web page in about:accounts, with a lot of screen available, I don't think it's good enough for mobile screens.
Comment 5•10 years ago
|
||
How about a checkbox underneath? http://lwaldal.files.wordpress.com/2013/08/android_show_password.jpg http://learnpad.co/support/tablet/img/wifi-password.png Or eliminate the feature entirely: Android already has a system-wide "Make passwords visible" setting.
Reporter | ||
Comment 6•10 years ago
|
||
Checkbox below would work, but we probably need a better string ("Show password", not just "Show").
Comment 7•10 years ago
|
||
Reason for re-implementing system features?
Assignee | ||
Comment 9•10 years ago
|
||
See also Bug 962622, which tracks working around an Android (Gingerbread only?) bug with rounded corners. If we were to remove the Show/Hide button entirely, or to move to a "Show password" check-box, we could get rid of the code that triggers the round corner bug above.
Assignee | ||
Comment 10•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/8a3bc080200e
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
status-firefox28:
--- → unaffected
status-firefox29:
--- → affected
status-firefox30:
--- → affected
status-firefox31:
--- → fixed
Flags: needinfo?(jgruen)
Comment 11•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8a3bc080200e
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
Comment 12•10 years ago
|
||
Verified as fixed on: Build: 31.0a2 (2014-05-15) Devices: Galaxy Nexus (Android 4.2.1) Asus Transformer Pad TF300T (Android 4.2.1)
Comment 13•10 years ago
|
||
Considering that the Firefox 30 has landed I will change flags from FF29 and FF30 to wontfix; Based on comment 12 I will mark the bug as verified.
Status: RESOLVED → VERIFIED
Updated•7 years ago
|
Product: Android Background Services → Firefox for Android
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•