975037 - Inline nsPersistentProperties::Init

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Andrew McCreight [:mccr8]]

This function is trivial and is only called in one place.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: part 1 - Inline nsPersistentProperties::Init.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Use smart pointers in nsPersistentProperties.

https://tbpl.mozilla.org/?tree=Try&rev=919977e5c90b

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: part 3 - Remove trailing whitespace from nsPersistentProperties.

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8379767 [details] [diff] [review]
part 2 - Use smart pointers in nsPersistentProperties.

Review of attachment 8379767 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, more like this.

Comment 5

[Andrew McCreight [:mccr8]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/d3e372d1c88a
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/a180f34d3eb7

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d3e372d1c88a
https://hg.mozilla.org/mozilla-central/rev/a180f34d3eb7
https://hg.mozilla.org/mozilla-central/rev/bfbdc2717985