975056 - [capi] fix check for NULL ptr lack in nss_ckcapi_CreatePrivateKey()

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Maks Naumov]

Attachment: null_ptr.patch

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0 (Beta/Release)
Build ID: 20140212131424

Steps to reproduce:

.\security\nss\lib\ckfw\capi\cobject.c -- 2160

  providerName = ckcapi_getDefaultProvider(pError);
  if ((char *)NULL == providerName ) { // << ========
    return (ckcapiInternalObject *)NULL;
  }
  containerName = ckcapi_getContainer(pError, &keyID);
  if ((char *)NULL == providerName ) { // << ========

Comment 1

[Elio Maldonado]

Comment on attachment 8379179 [details] [diff] [review]
null_ptr.patch

Review of attachment 8379179 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you Maks for the patch. r+ in general. You must have done it on the mozilla central source tree judging for the security path so it doesn't apply cleanly on the NSS tree. I'll attach a modified version of your patch that's easier to apply.

Comment 2

[Elio Maldonado]

Attachment: Maks Naumov's patch modified for the NSS source tree

Comment 3

[Robert Relyea]

Comment on attachment 8392962 [details] [diff] [review]
Maks Naumov's patch modified for the NSS source tree

r+ rrelyea

Comment 4

[Elio Maldonado]

Patch checked in: http://hg.mozilla.org/projects/nss/rev/a0115aed4a14