975059 - [FxA] Password not remembered in desktop Firefox after sync fails due to connection error

Status: RESOLVED WORKSFORME

(Firefox :: Sync, defect)

Description

[Matt Brubeck (:mbrubeck)]

Steps to reproduce:
1) Disconnect your phone or computer from the internet (e.g. using "Airplane mode").
2) Wait for sync to run and fail (or force a sync by entering Weave.Service.sync() in the Browser Console).
3) Re-connect to the internet.

Expected results: Sync resumes working after step 3.

Actual results: Sync remains disconnected after step 3, until you re-connect by entering your password.

This is extremely inconvenient when I have to put my phone or laptop into airplane mode, since re-entering my >20-character passphrase is time-consuming and error-prone (especially on mobile), and is only possible if I have it memorized.  I've seen it on both Android and desktop.

Sync should try to reconnect using the saved credentials, and should require re-entry only after authentication failures (not after connection failures).

Comment 1

[James Bonacci [:jbonacci]]

Review for desktop vs. android vs. both

Comment 2

[Richard Newman [:rnewman]]

Matt: do you have an adb log for this happening on Android?

Comment 3

[Nick Alexander :nalexander [he/him]]

> This is extremely inconvenient when I have to put my phone or laptop into
> airplane mode, since re-entering my >20-character passphrase is
> time-consuming and error-prone (especially on mobile), and is only possible
> if I have it memorized.  I've seen it on both Android and desktop.

On Android we're quite careful to only re-request your PW on an explicit 401 from the remote server, so I'd want to see logs before I believe it.  (It is of course possible we're buggy :)

Comment 4

[Matt Brubeck (:mbrubeck)]

I don't have a log for the Android case, and I can't seem to reproduce it on demand.  (The steps from comment 0 will reproduce the bug on desktop, but they don't reproduce for me on Android.)  I did see the same symptoms on Android after having my phone disconnected from the network over the weekend, but perhaps this was a separate bug from the one that is reproducible on desktop.

Let's use this bug for the easily-reproduced desktop case, and I'll file a separate bug for the Android case if I see it again in a current build, or can find more info about it.

Comment 5

[Mark Hammond [:markh] [:mhammond]]

I can't reproduce this on desktop.  What I did was:

* Start Fx already configured for FxA sync.  Perform a sync.
* With Fx still running, disabled my network adaptor.
* Tools -> Sync now - which after some time failed with the logs showing "Status.sync: success.sync => error.login.reason.network"
* Noted that sync displayed an error notification in the bottom of the browser, which included a "sync now" button.
* Verified that the Sync Prefs pane still shows me as logged in.
* Re-enabled my network adaptor.
* Clicked the "Sync Now" button in the notification.

Sync then started and completed as normal.  Sync Prefs still shows me as logged in.

Is there something I did wrong above?

Comment 6

[Matt Brubeck (:mbrubeck)]

Grr, I can't reproduce this now either, though I swear I could reproduce it just this morning.  My current theory is that my build was several days out of date and this has already been fixed on trunk.

I'm going to close this for now, but I'll try a few more things and will reopen it if I'm wrong.