Remove public interfaces that take a tinyid

RESOLVED FIXED in mozilla30

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

Trunk
mozilla30
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

These are no longer used by the browser, so we can at least remove the public interface. It looks like the shortid_ field is still used for StaticBlockObject though, so more work will be required internally. We can at least prevent new external uses, however.
Attachment #8379192 - Flags: review?(luke)
Comment on attachment 8379192 [details] [diff] [review]
remove_tinyid_interfaces-v0.diff

Whoa, awesome!  Did you remove them?

Also, we can surely get rid of static block object's shortid.  It'd be great to have that confusion gone.
Attachment #8379192 - Flags: review?(luke) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/4027d48cbc51

(In reply to Luke Wagner [:luke] from comment #1)
> Comment on attachment 8379192 [details] [diff] [review]
> remove_tinyid_interfaces-v0.diff
> 
> Whoa, awesome!  Did you remove them?

Nope, Boris mentioned a couple of weeks ago that there was only one user left. I figured removing the API would point me at the user, but it had apparently disappeared in the meantime.
 
> Also, we can surely get rid of static block object's shortid.  It'd be great
> to have that confusion gone.

The use of shortid_ for both tinyid and StaticBlockObject is so bonkers that I have trouble believing I am reading the code correctly.
This is a good start. JSPropertySpec in jsapi.h still has a tinyid.
https://hg.mozilla.org/mozilla-central/rev/4027d48cbc51
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.