975069 - Remove public interfaces that take a tinyid

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

Attachment: remove_tinyid_interfaces-v0.diff

These are no longer used by the browser, so we can at least remove the public interface. It looks like the shortid_ field is still used for StaticBlockObject though, so more work will be required internally. We can at least prevent new external uses, however.

Comment 1

[Luke Wagner [:luke]]

Comment on attachment 8379192 [details] [diff] [review]
remove_tinyid_interfaces-v0.diff

Whoa, awesome!  Did you remove them?

Also, we can surely get rid of static block object's shortid.  It'd be great to have that confusion gone.

Comment 2

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4027d48cbc51

(In reply to Luke Wagner [:luke] from comment #1)
> Comment on attachment 8379192 [details] [diff] [review]
> remove_tinyid_interfaces-v0.diff
> 
> Whoa, awesome!  Did you remove them?

Nope, Boris mentioned a couple of weeks ago that there was only one user left. I figured removing the API would point me at the user, but it had apparently disappeared in the meantime.
 
> Also, we can surely get rid of static block object's shortid.  It'd be great
> to have that confusion gone.

The use of shortid_ for both tinyid and StaticBlockObject is so bonkers that I have trouble believing I am reading the code correctly.

Comment 3

[Tom S. (please needinfo tschuster)]

This is a good start. JSPropertySpec in jsapi.h still has a tinyid.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4027d48cbc51

Comment 5

[Jason Orendorff [:jorendorff]]

\o/