975110 - Assertion failure: isFinished, at jit/shared/IonAssemblerBuffer.h

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: stack

"a" or "b" or "0" (Any single character)

asserts js debug shell on asmbuffer changeset fadec62359d5 with --ion-parallel-compile=off --ion-eager -D at Assertion failure: isFinished, at jit/shared/IonAssemblerBuffer.h

My configure flags are:

CC="gcc -mfloat-abi=softfp -B/usr/lib/gcc/arm-linux-gnueabi/4.7" AR=ar CXX="g++ -mfloat-abi=softfp -B/usr/lib/gcc/arm-linux-gnueabi/4.7" sh ./configure --target=arm-linux-gnueabi --enable-optimize --enable-debug --enable-profiling --enable-gczeal --enable-debug-symbols --enable-methodjit --enable-type-inference --disable-tests --enable-more-deterministic --enable-exact-rooting --with-ccache --enable-threadsafe <other NSPR options>

autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   7f6bcda3df42
tag:         tip
user:        Douglas Crosher
date:        Sat Feb 15 00:20:51 2014 +1100
summary:     Bug 972710 Ionmonkey: misc source clean up of the assembler buffer code, remove unused variables and dead code, add a few comments, etc.

Comment 1

[Douglas Crosher [:dougc]]

Attachment: Add an accessor for the intermediate assembler buffer size and use it for the script count block instruction estimates.

Implement the option suggested in bug 972710 comment 9 to use the intermediate buffer size as an estimate.  Still seeking feedback.  x86/x64 support still needs to be considered. To be reviewed as part of bug 972710.  

Landed on the asmbuffer repo to prevent blocking fuzzing.
https://hg.mozilla.org/users/dtc-moz_scieneer.com/asmbuffer/rev/0c1db7078286

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8379377 [details] [diff] [review]
Add an accessor for the intermediate assembler buffer size and use it for the script count block instruction estimates.

Review of attachment 8379377 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 3

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Fixed in the asmbuffer repo rev 0c1db7078286.