975130 - [B2G][Homescreen][E.me] Facebook and Twitter have square icons when adding them to homescreen

Status: RESOLVED DUPLICATE of bug 1022337

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Tony Nguyen]

Attachment: screenshot

Description:
Searching Facebook and Twitter then adding them to homescreen will have their icons displayed with square angles rather than rounded icons. 

Repro Steps:
1) Updated Buri to BuildID: 20140220040203
2) Tap on the Search on the top left of the screen
3) Tap in "Search or type address" to bring up keyboard
4) Type in "Twitter" and tap on Twitter icon
5) Tap on the bottom left "^" icon then tap on the star icon 
6) Tap on grey Twitter button to add to Home Screen
7) Tap "Add to Home Screen" button
8) Tap on the home button twice to return to homescreen

Actual Result:
Twitter icon is square shaped

Expected Result:
Twitter icon is circular rounded shaped

Environmental Variables:
Device: Buri Master M-C mozRIL
BuildID: 20140220040203
Gaia: 6e71ab4da1b08586ea0c758edb7aa199ee34cd2f
Gecko: 660b62608951
Version: 30.0a1
v1.2-device.cfg

Comment 1

[Jason Smith [:jsmith]]

Are all icons being generated here square?

Comment 2

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #1)
> Are all icons being generated here square?

As in, try testing with other e.me apps & see if this happens across the board with all e.me apps.

Comment 3

[Tony Nguyen]

Attachment: screenshot2

I tried this issue on the latest Master M-C build. It appears that every app that I search for, then adding to homescreen will have a squared icon. When adding apps from collections however, will display rounded icons. I've attached a screenshot showing the issue. 

Environmental Variables:
Device: Buri Master M-C mozRIL
BuildID: 20140221040202
Gaia: 35365feace970bfc51276428f40a477c9c86b7bb
Gecko: 7010ab83a06e
Version: 30.0a1
v1.2-device.cfg

Comment 4

[Jason Smith [:jsmith]]

UX - This isn't intentional, right? I thought we had VD requirements that required these icons to be round.

Comment 5

[Stephany Wilkes]

All our icons should be round, yes. If necessary I can confirm with Marketplace that we enforce this with app developers.

Comment 6

[Kevin Grandon :kgrandon]

Can you verify that these are apps added from rocketbar, or the existing homescreen search bar? We've recently disabled rocketbar for 1.4, so I'm wondering if it's a regression of the homescreen, or lack of implementation from rocketbar. Thanks!

 - Turns out we disabled rocketbar on 2/22, and the last m-c test was done on 2/21, so I'm assuming that it's a rocketbar issue?

Comment 7

[Ran Ben Aharon [:ranbena] EverythingMe]

I assume this is an E.me icon issue that was briefly discussed in https://bugzilla.mozilla.org/show_bug.cgi?id=971268#c14.

E.me icons arrive as square jpeg images from the API (for responses to be as light as possible) and the Rocketbar makes them round with css. The browser gets the original square icon and sets it as the homescreen icon - that's the reason for the bug.

IMO the best approach would be to round E.me icons (using canvas), the moment they're retrieved from the API. That way, all other Gaia components can stay oblivious to the square original.

Kevin, any objections?

Comment 8

[Jason Smith [:jsmith]]

(In reply to Kevin Grandon :kgrandon from comment #6)
> Can you verify that these are apps added from rocketbar, or the existing
> homescreen search bar? We've recently disabled rocketbar for 1.4, so I'm
> wondering if it's a regression of the homescreen, or lack of implementation
> from rocketbar. Thanks!
> 
>  - Turns out we disabled rocketbar on 2/22, and the last m-c test was done
> on 2/21, so I'm assuming that it's a rocketbar issue?

Note - this was tested while rocketbar was enabled.

Comment 9

[Kevin Grandon :kgrandon]

(In reply to Stephany Wilkes from comment #5)
> All our icons should be round, yes. If necessary I can confirm with
> Marketplace that we enforce this with app developers.

We don't enforce this with app developers - and I don't think it would be a good idea to do this. App developers should have the freedom to maintain their branding consistency across platforms.

(In reply to Ran Ben Aharon (Everything.me) from comment #7)
> 
> IMO the best approach would be to round E.me icons (using canvas), the
> moment they're retrieved from the API. That way, all other Gaia components
> can stay oblivious to the square original.
> 
> Kevin, any objections?

I really like the current simplicity of the current rounding solution in the search app. I would personally recommend trying to carry this over to the homescreen app as well.

Comment 10

[Ran Ben Aharon [:ranbena] EverythingMe]

(In reply to Kevin Grandon :kgrandon from comment #9)
> 
> I really like the current simplicity of the current rounding solution in the
> search app. I would personally recommend trying to carry this over to the
> homescreen app as well.

I understand. That would mean that both the Homescreen and Search app are required to recognize an E.me result. This is something we've always aspired to diminish. IMO both apps should remain agnostic.

Anywho, this is just my opinion. Any course of action is fine by me.

Comment 11

[Amir Nissim (:amirn)]

Was fixed in bug 1022337 for vertical homescreen.

As Jason noted in comment 8, this happened with horizontal homescreen and rocketbar encable which is not a supported setup.