97514 - windowwatcher needs to be informed of window creation/deletion

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Dan M]

WindowWatcher claims to be able to enumerate through open top-level windows (see 
the idl) much like WindowMediator. (NB Watcher is an embedding-oriented version 
of the Mozilla-app-oriented Mediator). This currently works in the embedded apps 
but not in Mozilla because Mozilla never notifies Watcher of window creation or 
removal.

Comment 1

[Dan M]

Attachment: hook up windowwatcher window notifications to enable its enumerators

Comment 2

[Dan M]

the above patch is a little confusing and appears uglier than it really is 
because I fixed some tabbed and fibonacci indentation, and the diff was made 
ignoring white space changes.

Comment 3

[Paul Chen]

r=pchen

Comment 4

[Dan M]

.

Comment 5

[(not reading, please use [e-mail] instead)]

reopening.  I had to back this out because it caused a smoketest blocker 
regression.

see http://bugzilla.mozilla.org/show_bug.cgi?id=98732

Comment 6

[Conrad Carlen (not reading bugmail)]

This also was causing a crash when exiting in -turbo mode because of this
call-site:
http://lxr.mozilla.org/mozilla/source/xpfe/bootstrap/nsNativeAppSupportWin.cpp#1264

Comment 7

[Dan M]

The regression was caused by this patch exposing another bug 98785. That has been 
fixed, so I'm reinstating this patch and reclosing the bug. Thanks for covering 
for me, Seth. Oh, and I've added a null check to fix the crasher Conrad mentions 
above. I think the real problem there is a misuse of the function. That can be 
fixed by bug 98792, but until that happy day, there's a null check.