Closed
Bug 975141
Opened 10 years ago
Closed 10 years ago
Firefox OS form should support utm_source and utm_campaign
Categories
(Input Graveyard :: Submission, defect, P1)
Input Graveyard
Submission
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: willkg, Assigned: willkg)
References
Details
(Whiteboard: u=user c=feedback p=2 s=input.2014q2)
The Firefox OS form doesn't currently support the utm_source and utm_campaign querystring parameters. We need to add support for that. The Firefox OS form uses the Input API to send data, so we'll need to update the Input API first.
Assignee | ||
Comment 1•10 years ago
|
||
I think this is going to be a little complicated, so making it a 2 pointer. Making it block on bug #975140.
Depends on: 975140
Whiteboard: u=user c=feedback p=2 s=input.2014q1
Assignee | ||
Comment 2•10 years ago
|
||
There are two ways we can deal with this: 1. have the Django template for the fxos_feedback form grab the querystring params and put them in data- fields or hidden inputs then have the JavaScript grab that and send it along with the jqxhr, 2. have JavaScript grab the querystring params and send along with the jqxhr The second sounds easier--at a minimum the sentence is shorter. That JavaScript file is in fjord/feedback/static/js/mobile/fxos_feedback.js I think. This is a mentored bug. If you're interested in working on it, comment here or ping willkg in #input on irc.freenode.net.
Whiteboard: u=user c=feedback p=2 s=input.2014q1 → u=user c=feedback p=2 s=input.2014q1 [mentor=willkg]
Assignee | ||
Comment 3•10 years ago
|
||
Moving this to 2014q2.
Priority: -- → P1
Whiteboard: u=user c=feedback p=2 s=input.2014q1 [mentor=willkg] → u=user c=feedback p=2 s=input.2014q2 [mentor=willkg]
Assignee | ||
Comment 4•10 years ago
|
||
Grabbing this to fix now. This is the last of the source/campaign-related bugs.
Assignee: nobody → willkg
Whiteboard: u=user c=feedback p=2 s=input.2014q2 [mentor=willkg] → u=user c=feedback p=2 s=input.2014q2
Assignee | ||
Comment 5•10 years ago
|
||
In a PR: https://github.com/mozilla/fjord/pull/305
Assignee | ||
Comment 6•10 years ago
|
||
Landed in https://github.com/mozilla/fjord/commit/7d0a4a0
Assignee | ||
Comment 7•10 years ago
|
||
Pushed to prod just now.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Input → Input Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•