975162 - remove block's use of shortid

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Luke Wagner [:luke]]

Turns out these days that a block shape's shortid is just
  (shape.slot() - BlockObject::RESERVED_SLOTS)
This is the last use of shortids so time to remove.

While at it, I found that wingo's recent UnwindScope work means we can also remove the int-named "destructuring dummies" that get inserted into blocks.

Comment 1

[Luke Wagner [:luke]]

Attachment: rm-empty-destr-goofiness

Comment 2

[Luke Wagner [:luke]]

Attachment: rm-block-shortid

Comment 3

[Luke Wagner [:luke]]

Attachment: rm-empty-destr-goofiness

Removed unintentional hunk in previous patch.

Comment 4

[Andy Wingo [:wingo]]

Comment on attachment 8379311 [details] [diff] [review]
rm-block-shortid

Review of attachment 8379311 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent :)

Comment 5

[Andy Wingo [:wingo]]

Comment on attachment 8379415 [details] [diff] [review]
rm-empty-destr-goofiness

Review of attachment 8379415 [details] [diff] [review]:
-----------------------------------------------------------------

five stars, two thumbs up, would review again

Comment 6

[Luke Wagner [:luke]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/879e31a2f667
https://hg.mozilla.org/integration/mozilla-inbound/rev/343aac1bb02e

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/879e31a2f667
https://hg.mozilla.org/mozilla-central/rev/343aac1bb02e