Closed Bug 975162 Opened 6 years ago Closed 6 years ago

remove block's use of shortid

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: luke, Assigned: luke)

References

Details

Attachments

(2 files, 1 obsolete file)

Turns out these days that a block shape's shortid is just
  (shape.slot() - BlockObject::RESERVED_SLOTS)
This is the last use of shortids so time to remove.

While at it, I found that wingo's recent UnwindScope work means we can also remove the int-named "destructuring dummies" that get inserted into blocks.
Attached patch rm-empty-destr-goofiness (obsolete) — Splinter Review
Attachment #8379309 - Flags: review?(wingo)
Attached patch rm-block-shortidSplinter Review
Attachment #8379311 - Flags: review?(wingo)
Removed unintentional hunk in previous patch.
Attachment #8379309 - Attachment is obsolete: true
Attachment #8379309 - Flags: review?(wingo)
Attachment #8379415 - Flags: review?(wingo)
Comment on attachment 8379311 [details] [diff] [review]
rm-block-shortid

Review of attachment 8379311 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent :)
Attachment #8379311 - Flags: review?(wingo) → review+
Comment on attachment 8379415 [details] [diff] [review]
rm-empty-destr-goofiness

Review of attachment 8379415 [details] [diff] [review]:
-----------------------------------------------------------------

five stars, two thumbs up, would review again
Attachment #8379415 - Flags: review?(wingo) → review+
https://hg.mozilla.org/mozilla-central/rev/879e31a2f667
https://hg.mozilla.org/mozilla-central/rev/343aac1bb02e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.